Fields not hidden in header during preview

[Ryan J Ollos]

The hidden fields are still visible in the #ticket during preview.

[Ryan J Ollos]

#13214 closed as a duplicate.

[Jun Omae]

Workaround:

dynfields/htdocs/dynfields.js

@@ -74 +74 @@
       $(this).change(apply_rules).change();
     });
 
+    // apply rules on preview
+    $(document).ajaxComplete(function(event, xhr, settings) {
+      if (settings.url === location.pathname) {
+        $.each(inputs, function() { $(this).change() });
+      }
+    });
   }
 });

[Ryan J Ollos]

Thanks for the patch. I tested with Trac 1.0.18dev. There is a minor issue. Using the following config:

[ticket-custom]
parents = text
parents.label = Parent Tickets
parents.hide_when_milestone =

Starting with an empty milestone, change milestone to milestone1. Parents Tickets appears in #properties, but does not appear in #ticket, during explicit preview, auto-preview and after submit. It seems Parent Tickets is always hidden in #ticket.

[Jun Omae]

It seems that the wrong layout in #ticket is introduced in [15095].

dynfields/htdocs/rules.js

@@ -168 +168 @@
   // hide field in the header if cleared or always hidden
   var clear_on_hide = spec.clear_on_hide.toLowerCase() == 'true';
   var hide_always = spec.hide_always.toLowerCase() == 'true'
-  if (clear_on_hide || hide_always) {
-    th = jQuery('#h_' + spec.target);
-    td = th.next('td');
-    td.addClass('dynfields-hide dynfields-' + trigger);
-    th.addClass('dynfields-hide dynfields-' + trigger);
-  }
 
   if (input.attr('id').slice(6) !== spec.trigger)
     return;
@@ -199 +193 @@
     th.addClass(cls);
 
     // let's also clear out the field's value to avoid confusion
-    if (spec.clear_on_hide.toLowerCase() == 'true' &&
+    if (clear_on_hide &&
       field.val() && field.val().length) { // Chrome fix - see #8654
       if (field.attr('type') == 'checkbox') {
         if (field.is(':checked')) {
@@ -213 +207 @@
           field.change(); // cascade rules
       }
     }
+    if (clear_on_hide || hide_always) {
+      th = jQuery('#h_' + spec.target);
+      td = th.next('td');
+      td.addClass('dynfields-hide dynfields-' + trigger);
+      th.addClass('dynfields-hide dynfields-' + trigger);
+    }
   }
 };
 

[Jun Omae]

See also posted patch (dynamicfieldsplugin-v2.diff) in ​gmessage:trac-users:Bn3rGvLfRVc/aq_aeJWnAQAJ.

[Ryan J Ollos]

Sorry for delay, I had intended to test and commit, but not sure I will get it done soon. Please feel free to commit the changes, and those in #9606 as well.

[Ryan J Ollos]

I unintentionally committed the comment:6 change in r17397, but probably is a needed change anyway.

[Ryan J Ollos]

In 17434:

TracDynamicFields 2.3.0dev: Fix regression in r15095

Patch by Jun Omae.

Refs #12575.

[Ryan J Ollos]

Replying to Jun Omae:

See also posted patch (dynamicfieldsplugin-v2.diff) in ​gmessage:trac-users:Bn3rGvLfRVc/aq_aeJWnAQAJ.

Rebased the patch: dynamicfieldsplugin-v3.diff​. Will do more testing.

[Ryan J Ollos]

In 17522:

TracDynamicFields 2.3.0dev: Fix fields not hidden in header during preview

Patch by Jun Omae.

Refs #12575, #9606.