Submit button to the wrong URL address?

[johnt888@…]

Hi -

I installed the plugins, but it pointed to the wrong address when I clicked the Submit button. Could you help for the possible issues?

Our Trac is set up based on Apache server and it looks like:

​https://www.abc.com/trac/example

But when I clicked the Submit button, it points to:

​https://www.abc.com/accreditation/new

It doesn't exist ... Does this plugin apply to the standalone trac server only?

thanks!

[Ryan J Ollos]

I believe the following untested patch will fix the issue:

accreditationplugin/trunk/Accreditation/Accreditation.py

@@ -86 +86 @@
 
             ticket.save_changes(req.authname, "Launched New Accreditation '''%s'''" % topic)
 
-            req.redirect('/ticket/' + str(id))
+            req.redirect(req.href.ticket(id))
 
         elif req.path_info.startswith('/accreditation/comment'):
 
@@ -107 +107 @@
 
             ticket.save_changes(req.authname, "Accredited '''%s''' for \"''%s''\".\n\n%s" % (topic, conclusion, comment))
 
-            req.redirect('/ticket/' + str(id))
+            req.redirect(req.href.ticket(id))
 
     def filter_stream(self, req, method, filename, stream, data):

[Ryan J Ollos]

Replying to johnt888@…:

It doesn't exist ... Does this plugin apply to the standalone trac server only?

Just for future consideration, I wouldn't worry too much about plugins applying to TracStandalone only. In some cases there may be defects that are only revealed when running with certain configurations, but they are usually easily correctable and all plugins should work with TracStandalone and a "real" webserver.

[Cauly]

In 15068:

bug fix #12582

[Cauly]

Thanks a lot, rjollos

[johnt888@…]

Thanks for the patch and it works for first Submit button now. But I put the "Conclusion" & "Comment" and clicked Submit button ... It points to the following URL, but it doesn't exist.

​https://www.abc.com/trac/example/accreditation/comment

Could you help check the issue is?

Thanks again!

[johnt888@…]

Here is the output from Trac:

File "build/bdist.linux-x86_64/egg/Accreditation/Accreditation.py", line 98, in process_request

Code fragment:

Line

93

94

req.redirect(req.href('ticket', id))

95

96

elif req.path_info.startswith('/accreditation/comment'):

97

98

id = int(req.argsticket?)

99

topic = req.argstopic?

100

author = req.authname

101

conclusion = req.argsconclusion?

102

comment = req.argscomment?

103

[johnt888@…]

Hmm... It works if I create a new ticket. The existing tickets(before installing this plugin) won't work. If it only applies to the new ticket after installation of the plugins, it should be fine.

thanks!

[Ryan J Ollos]

Replying to johnt888@…:

Here is the output from Trac:

File "build/bdist.linux-x86_64/egg/Accreditation/Accreditation.py", line 98, in process_request

Please take moment to review the WikiFormatting page so that you can post content that is readable.

[johnt888@…]

sorry to generate the messy format in my previous updates ... Not sure the root cause is, but it's working for the old tickets after I close IE/clean caches. thanks and sorry for false alarm.

[Ryan J Ollos]

No problem, thanks for the fast reply.