Modify

Opened 6 years ago

Closed 5 years ago

#12736 closed defect (fixed)

javascript error in testman4trac/testmanager/htdocs/js/testmanager.js

Reported by: erik@… Owned by: Roberto Longobardi
Priority: normal Component: TestManagerForTracPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Release 2015-11-22 . Safari and chrome show a syntax error, the following patch fixes these:

diff --git a/testman4trac/testmanager/htdocs/js/testmanager.js b/testman4trac/testmanager/htdocs/js/testmanager.js
index 3442102..5bc09dc 100644
--- a/testman4trac/testmanager/htdocs/js/testmanager.js
+++ b/testman4trac/testmanager/htdocs/js/testmanager.js
@@ -83,15 +83,14 @@ function createTestPlanConfirm(catName) {
     var testplanSnapshot = $("input[@name=testplan_snapshot]:checked").val();
        */
 
-    var nodes = $("input[@name='testplan_contains_all']:checked");
+    var nodes = $("input[name='testplan_contains_all']:checked");
     for (var i=0; i<nodes.length; i++) {
         var node = nodes[i];
         if (node.name == 'testplan_contains_all') {
             testplanContainsAll = node.value;
         }
     }
-
-    nodes = $("input[@name='testplan_snapshot']:checked");
+    nodes = $("input[name='testplan_snapshot']:checked");
     for (var i=0; i<nodes.length; i++) {
         var node = nodes[i];
         if (node.name == 'testplan_snapshot') {

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by Roberto Longobardi

Resolution: fixed
Status: newclosed

Thanks a lot for the patch.

Included in release 1.9.1 now available from SourceForge.

https://sourceforge.net/projects/testman4trac/files

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Roberto Longobardi.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.