Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12821 closed defect (fixed)

AttributeError: 'bool' object has no attribute 'repos'

Reported by: 155466@… Owned by: Ryan J Ollos
Priority: normal Component: CodeReviewerPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

How to Reproduce

While doing a GET operation on /changeset, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{u'new': u'37@/', u'old': u'35@/', u'reponame': u'tcny'}

User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

System Information

Trac 1.0.11
Genshi 0.7 (without speedups)
pysqlite 2.6.0
Python 2.7.11 (v2.7.11:6d1b6a68f775, Dec 5 2015, 20:32:19) [MSC v.1500 32 bit (Intel)]
setuptools 24.0.2
SQLite 3.6.21
Subversion 1.9.4 (r1740329)
jQuery 1.7.2
jQuery UI 1.8.21
jQuery Timepicker 1.0.1

Enabled Plugins

hudsontrac 0.5.post0
traccodereviewer 1.0.0.dev0
tracdynamicfields 2.2.0

Python Traceback

Traceback (most recent call last):
  File "c:\users\cuzhang\appdata\local\temp\easy_install-te1p8h\Trac-1.0.11-py2.7-win-amd64.egg.tmp\trac\web\main.py", line 562, in _dispatch_request
    dispatcher.dispatch(req)
  File "c:\users\cuzhang\appdata\local\temp\easy_install-te1p8h\Trac-1.0.11-py2.7-win-amd64.egg.tmp\trac\web\main.py", line 259, in dispatch
    self._post_process_request(req, *resp)
  File "c:\users\cuzhang\appdata\local\temp\easy_install-te1p8h\Trac-1.0.11-py2.7-win-amd64.egg.tmp\trac\web\main.py", line 396, in _post_process_request
    resp = f.post_process_request(req, *resp)
  File "build\bdist.win32\egg\coderev\web_ui.py", line 71, in post_process_request
    repos, rev = changeset.repos.reponame, changeset.rev
AttributeError: 'bool' object has no attribute 'repos'

Attachments (2)

shot1.png (245.3 KB) - added by 155466@… 8 years ago.
When different Rev selected in 'diff' column and click The error screenshot
shot1.2.png (245.3 KB) - added by 155466@… 8 years ago.
When different Rev selected in 'diff' column and click 'View changes', the error happened, please reference attached screenshot

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by 155466@…

Attachment: shot1.png added

When different Rev selected in 'diff' column and click The error screenshot

Changed 8 years ago by 155466@…

Attachment: shot1.2.png added

When different Rev selected in 'diff' column and click 'View changes', the error happened, please reference attached screenshot

comment:1 Changed 8 years ago by Ryan J Ollos

Have you defined your repositories in the database or in trac.ini? If trac.ini, could you post your [repositories] section? If the database, could you post the output of trac-admin $env repository list?

comment:2 in reply to:  1 Changed 8 years ago by anonymous

Replying to rjollos:

Have you defined your repositories in the database or in trac.ini? If trac.ini, could you post your [repositories] section? If the database, could you post the output of trac-admin $env repository list?

I defined the repositories in trac.ini as the below:

# -*- coding: utf-8 -*-

[hudson]
job_url = http://win10-SVN:8082/job/TCNY/

[inherit]
file = c:\trac\share\conf\trac.ini

[project]
descr = TCNY project
name = TCNY

[repositories]
.alias = TCNY
tcny.description = This is the ''TCNY'' project repository.
tcny.dir = C:\svn_repository\TCNY
tcny.hidden = false
tcny.type = svn
tcny.url = http://WIN10-SVN:8088/svn/TCNY/

[ticket]
default_priority = medium
default_severity = major
default_version = 1.0

comment:3 Changed 8 years ago by Ryan J Ollos

Owner: changed from Rob Guttman to Ryan J Ollos
Status: newaccepted

comment:4 Changed 8 years ago by Ryan J Ollos

The error occurs when viewing a diff. The plugin shouldn't try to add the code reviewer functions when viewing a diff.

comment:5 Changed 8 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 15732:

1.0.0dev: Don't add code reviewer when viewing a diff

Fixes #12821.

comment:6 Changed 8 years ago by Ryan J Ollos

In 15743:

1.0.0dev: Account for data being None for some requests

Addendum to r15732.

Refs #12821.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.