Modify

Opened 6 years ago

Closed 6 years ago

#12887 closed defect (fixed)

Plugin fails to install

Reported by: bitelxux@… Owned by: tkob-trac
Priority: normal Component: PdfPreviewPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description (last modified by Jun Omae)

root@7f228146d7# easy_install https://trac-hacks.org/svn/pdfpreviewplugin                    
Downloading https://trac-hacks.org/svn/pdfpreviewplugin
Doing subversion checkout from https://trac-hacks.org/svn/pdfpreviewplugin to /tmp/easy_install-EGWPnp/pdfpreviewplugin
Processing pdfpreviewplugin
Writing /tmp/easy_install-EGWPnp/pdfpreviewplugin/1.0/setup.cfg
Running 1.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-EGWPnp/pdfpreviewplugin/1.0/egg-dist-tmp-ha03Ur
error: Setup script exited with error: can't copy 'tracpdfpreview/htdocs/web': doesn't exist or not a regular file

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by Jun Omae

Description: modified (diff)

comment:2 Changed 6 years ago by Jun Omae

Please try the following patch.

  • pdfpreviewplugin/1.0/setup.py

    diff --git a/pdfpreviewplugin/1.0/setup.py b/pdfpreviewplugin/1.0/setup.py
    index a634c84..9a14e18 100644
    a b setup( 
    2020    },
    2121    package_data = {
    2222        'tracpdfpreview': [
    23             'htdocs/*',
    24             'htdocs/*/*',
    25             'htdocs/*/*/*',
     23            'htdocs/*.*',
     24            'htdocs/*/*.*',
     25            'htdocs/*/*/*.*',
     26            'htdocs/*/*/*/*.*',
     27            'htdocs/LICENSE',
     28            'htdocs/*/*/LICENSE',
    2629        ],
    2730    },
    2831)

comment:3 Changed 6 years ago by anonymous

The patch works. Thank you.

comment:4 Changed 6 years ago by tkob-trac

@jun66j5 Should I merge the patch? I have tested the following:

[vagrant@localhost ~]$ sudo pip install svn+https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
Collecting svn+https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
  Checking out https://trac-hacks.org/svn/pdfpreviewplugin/1.0/ to /tmp/pip-TslyNM-build
Installing collected packages: TracPdfPreview
  Running setup.py install for TracPdfPreview ... done
Successfully installed TracPdfPreview-0.1.1

and with easy_install:

[vagrant@localhost ~]$ sudo easy_install https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
Downloading https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
Doing subversion checkout from https://trac-hacks.org/svn/pdfpreviewplugin/1.0/ to /tmp/easy_install-ynl18N/__downloaded__
Processing __downloaded__
Writing /tmp/easy_install-ynl18N/__downloaded__/setup.cfg
Running setup.py -q bdist_egg --dist-dir /tmp/easy_install-ynl18N/__downloaded__/egg-dist-tmp-Dh8oM5
zip_safe flag not set; analyzing archive contents...
Moving TracPdfPreview-0.1.1-py2.7.egg to /usr/lib/python2.7/site-packages
Adding TracPdfPreview 0.1.1 to easy-install.pth file

Installed /usr/lib/python2.7/site-packages/TracPdfPreview-0.1.1-py2.7.egg
Processing dependencies for TracPdfPreview==0.1.1
Finished processing dependencies for TracPdfPreview==0.1.1

That is, the URL should point to ".../1.0/", where setup.py resides. Please let me know if I missed something.

comment:5 Changed 6 years ago by Jun Omae

Yeah, please merge it.

I've confirmed the numbers of files in htdocs directory between in source directory and *.egg file.

$ find tracpdfpreview/htdocs -type f | wc -l
367
$ unzip -l dist/*.egg | grep /htdocs/ | wc -l
367

comment:6 Changed 6 years ago by tkob-trac

In 15904:

Fix package_data. A patch by jun66j5. refs #12887

comment:7 Changed 6 years ago by tkob-trac

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain tkob-trac.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.