Plugin fails to install

[bitelxux@…]

root@7f228146d7# easy_install https://trac-hacks.org/svn/pdfpreviewplugin                    
Downloading https://trac-hacks.org/svn/pdfpreviewplugin
Doing subversion checkout from https://trac-hacks.org/svn/pdfpreviewplugin to /tmp/easy_install-EGWPnp/pdfpreviewplugin
Processing pdfpreviewplugin
Writing /tmp/easy_install-EGWPnp/pdfpreviewplugin/1.0/setup.cfg
Running 1.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-EGWPnp/pdfpreviewplugin/1.0/egg-dist-tmp-ha03Ur
error: Setup script exited with error: can't copy 'tracpdfpreview/htdocs/web': doesn't exist or not a regular file

[Jun Omae]

Please try the following patch.

pdfpreviewplugin/1.0/setup.py

@@ -20 +20 @@
     },
     package_data = {
         'tracpdfpreview': [
-            'htdocs/*',
-            'htdocs/*/*',
-            'htdocs/*/*/*',
+            'htdocs/*.*',
+            'htdocs/*/*.*',
+            'htdocs/*/*/*.*',
+            'htdocs/*/*/*/*.*',
+            'htdocs/LICENSE',
+            'htdocs/*/*/LICENSE',
         ],
     },
 )

[anonymous]

The patch works. Thank you.

[tkob-trac]

@jun66j5 Should I merge the patch? I have tested the following:

[vagrant@localhost ~]$ sudo pip install svn+https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
Collecting svn+https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
  Checking out https://trac-hacks.org/svn/pdfpreviewplugin/1.0/ to /tmp/pip-TslyNM-build
Installing collected packages: TracPdfPreview
  Running setup.py install for TracPdfPreview ... done
Successfully installed TracPdfPreview-0.1.1

and with easy_install:

[vagrant@localhost ~]$ sudo easy_install https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
Downloading https://trac-hacks.org/svn/pdfpreviewplugin/1.0/
Doing subversion checkout from https://trac-hacks.org/svn/pdfpreviewplugin/1.0/ to /tmp/easy_install-ynl18N/__downloaded__
Processing __downloaded__
Writing /tmp/easy_install-ynl18N/__downloaded__/setup.cfg
Running setup.py -q bdist_egg --dist-dir /tmp/easy_install-ynl18N/__downloaded__/egg-dist-tmp-Dh8oM5
zip_safe flag not set; analyzing archive contents...
Moving TracPdfPreview-0.1.1-py2.7.egg to /usr/lib/python2.7/site-packages
Adding TracPdfPreview 0.1.1 to easy-install.pth file

Installed /usr/lib/python2.7/site-packages/TracPdfPreview-0.1.1-py2.7.egg
Processing dependencies for TracPdfPreview==0.1.1
Finished processing dependencies for TracPdfPreview==0.1.1

That is, the URL should point to ".../1.0/", where setup.py resides. Please let me know if I missed something.

[Jun Omae]

Yeah, please merge it.

I've confirmed the numbers of files in htdocs directory between in source directory and *.egg file.

$ find tracpdfpreview/htdocs -type f | wc -l
367
$ unzip -l dist/*.egg | grep /htdocs/ | wc -l
367

[tkob-trac]

In 15904:

Fix package_data. A patch by jun66j5. refs #12887