linkresolvers should be sorted by name

[Jun Omae]

Currently, linkresolvers suggests unsorted link names. I think the suggestion should be sorted by name.

The 20 link resolvers are defined by Trac core.

>>> from trac.test import EnvironmentStub
>>> from trac.loader import load_components
>>> from trac.wiki.api import WikiSystem
>>> env = EnvironmentStub()
>>> load_components(env)
>>> wikisys = WikiSystem(env)
>>> names = set()
>>> for provider in wikisys.syntax_providers:
...   for name, resolver in provider.get_link_resolvers():
...     names.add(name)
...
>>> names = sorted(names)
>>> len(names)
20
>>> names
['attachment', 'browser', 'bug', 'changeset', 'comment', 'diff', 'export', 'htdocs', 'log', 'milestone', 'query', 'raw-attachment', 'report', 'repos', 'search', 'sha', 'source', 'ticket', 'timeline', 'wiki']

wikiautocomplete/htdocs/js/wikiautocomplete.js

@@ -78 +78 @@
 
     ], {
         appendTo: $('body'),
+        maxCount: 20
     });
 });

wikiautocomplete/web_ui.py

@@ -74 +74 @@
 
         if strategy == 'linkresolvers':
             wiki = WikiSystem(self.env)
-            completions = []
-            for provider in wiki.syntax_providers:
-                for name, resolver in provider.get_link_resolvers():
-                    if name.startswith(term):
-                        completions.append(name)
-            self._send_json(req, completions)
+            completions = set(name for provider in wiki.syntax_providers
+                                   for name, resolver
+                                        in provider.get_link_resolvers()
+                                   if name.startswith(term))
+            self._send_json(req, sorted(completions))
 
         elif strategy == 'ticket':
             try:

[Peter Suter]

maxCount: 20

I agree it is unfortunate that not all available resolvers are shown. I also agree that 10 (the default) is maybe often too small. But increasing maxCount is not a perfect solution. It will still be too small when plugins add more resolvers. 20 seems maybe a bit too large to me on smaller screens, but maybe acceptable.

I ​filed an issue upstream about scrolling through longer lists.

I think the suggestion should be sorted by name.

Sounds good. Please commit, thanks.

[Jun Omae]

The owner of jquery-textcomplete suggests to use max-height with large maxCount in ​the issue comment.

What about modifying like this?

wikiautocomplete/htdocs/css/jquery.textcomplete.css

@@ -3 +3 @@
 .dropdown-menu {
     border: 1px solid #ddd;
     background-color: white;
+    max-height: 20em;
+    overflow-x: hidden;
+    overflow-y: auto;
 }
 
 .dropdown-menu li {

wikiautocomplete/htdocs/js/wikiautocomplete.js

@@ -78 +78 @@
 
     ], {
         appendTo: $('body'),
+        maxCount: 10000
     });
 });

[Peter Suter]

Looks great, thanks!

[Jun Omae]

In 15946:

WikiAutoCompletePlugin: sort suggestion from linkresolvers and make the suggestion scrollable (closes #12925)