Complete attachment filenames

[Peter Suter]

It would be very helpful to get suggestions for attachment filenames.

(And also for attachment:ticket:123:filename.ext / attachment:wiki:pagename:filename.ext` if possible?)

[Jun Omae]

Proposed changes can be found in ​https://github.com/jun66j5/wikiautocompleteplugin/compare/master...t12930.

[Peter Suter]

Wow, I had a similar patch in the works, but this is much better, thanks!

[Jun Omae]

Thanks. Additional changes in ​https://github.com/jun66j5/wikiautocompleteplugin/commit/8c6adf83dd359b5f9ab1ce972ecfdd932b0b5f1d, fixing completion is broken when $ character is in the suggestion (e.g. SandBox/$1).

[anonymous]

Good catch!

[Peter Suter]

Good catch!

(I forgot to log in.)

[Jun Omae]

In 15947:

WikiAutoCompletePlugin: complete attachment filenames on attachment: and raw-attachment: links (closes #12930)

[Jun Omae]

Thanks for the reviewing! Committed in [15947].

[Jun Omae]

Hmm, [[Image()]] macro with attachment:... link doesn't work....

Ad hoc patch: complete attachments also when typing [[Image(. Thoughts?

wikiautocomplete/htdocs/js/wikiautocomplete.js

@@ -5 +5 @@
 
     $('textarea.wikitext').textcomplete([
         { // Attachment
-            match: /\b((?:raw-)?attachment):(\S*)$/,
+            match: /(\b(?:raw-)?attachment:|\[\[Image\()(\S*)$/,
             search: function (term, callback) {
                 $.getJSON(wikiautocomplete.url + '/attachment',
                           { q: term, realm: wikiautocomplete.realm,
@@ -17 +17 @@
             replace: function (name) {
                 if (/\s/.test(name))
                     name = '"' + name + '"';
-                return '$1:' + escape_newvalue(name);
+                return '$1' + escape_newvalue(name);
             },
             cache: true
         },

[Peter Suter]

complete attachments also when typing [[Image(. Thoughts?

I don't use [[Image()]] much, but I guess it's quite a common use-case? If only such a small tweak is required, I think it's a good idea.

More general macro arguments completion would be nice, but I don't know how it would work. Unless macros standardize on some formal parameter description.

This overrides the macro description​ preview​, right? (But that is maybe not very important.)

[Jun Omae]

Replying to psuter:

This overrides the macro description​ preview​, right? (But that is maybe not very important.)

Yes. After the patch, typing [[Image( would lead to show suggestion for attachments instead of Image macro's description.

[Jun Omae]

In 15962:

WikiAutoCompletePlugin: suggest attachments on typing [[Image( (refs #12930)