Modify

Opened 11 months ago

Closed 3 months ago

Last modified 3 months ago

#13018 closed defect (fixed)

MenusPlugin breaks on Superfish with Trac 1.2

Reported by: morgana2313 Owned by: Ryan J Ollos
Priority: normal Component: MenusPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Chrome browser gives the following javascript error:

superfish.js:64 Uncaught TypeError: Cannot read property 'msie' of undefined
    at HTMLUListElement.<anonymous> (superfish.js:64)
    at Function.each (jquery.js:2)
    at m.fn.init.each (jquery.js:2)
    at m.fn.init.$.fn.superfish (superfish.js:62)
    at HTMLDocument.<anonymous> (tracmenus.js:2)
    at j (jquery.js:2)
    at Object.fireWith [as resolveWith] (jquery.js:2)
    at Function.ready (jquery.js:2)
    at HTMLDocument.J (jquery.js:2)
(anonymous) @ superfish.js:64
each @ jquery.js:2
each @ jquery.js:2
$.fn.superfish @ superfish.js:62
(anonymous) @ tracmenus.js:2
j @ jquery.js:2
fireWith @ jquery.js:2
ready @ jquery.js:2
J @ jquery.js:2

Perhaps the Superfish version needs to be upgraded to be compatible with jquery > 1.9 ? https://stackoverflow.com/questions/14923301/uncaught-typeerror-cannot-read-property-msie-of-undefined-jquery-tools#14923480

Trac 1.1 uses JQuery 1.7, Trac 1.2 uses 1.11

Attachments (1)

menu.png (6.6 KB) - added by rednose 3 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 in reply to:  description ; Changed 10 months ago by Ryan J Ollos

Replying to morgana2313:

Perhaps the Superfish version needs to be upgraded to be compatible with jquery > 1.9 ? https://stackoverflow.com/questions/14923301/uncaught-typeerror-cannot-read-property-msie-of-undefined-jquery-tools#14923480

Could you give the upgrade a try to see if it resolves the issue? Let me know if you need any hints on updating the dependency in the plugin.

comment:2 Changed 8 months ago by Ryan J Ollos

Owner: Catalin BALAN deleted

comment:3 in reply to:  1 Changed 3 months ago by rednose

In my installation the plugin didn't crash, but was not able to show the menus properly. Menus and submenus were all displayed together in a large single line. I have now upgraded to superfish 1.7.9 and jquery-hoverIntent 1.8.1 and the plugin works again as with TRAC 1.0. (IE and firefox, I don't have chrome)

Last edited 3 months ago by Ryan J Ollos (previous) (diff)

comment:4 Changed 3 months ago by Ryan J Ollos

Thanks. Would you be willing to test the latest source for the plugin if I upgraded those libraries?

comment:5 in reply to:  4 Changed 3 months ago by anonymous

Replying to Ryan J Ollos:

Thanks. Would you be willing to test the latest source for the plugin if I upgraded those libraries?

I'll try ...

Last edited 3 months ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 3 months ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: newaccepted

comment:7 Changed 3 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 16733:

TracMenusPlugin 0.2.0: Upgrade superfish and hoverIntent

This adds basic support for Trac >= 1.2.
The CSS needs improvement. Patches welcome.

Fixes #13018, #11727.

comment:8 Changed 3 months ago by Ryan J Ollos

In 16734:

TracMenusPlugin 0.2.0: Restore missing styles

Fixes #13018, #11727.

Changed 3 months ago by rednose

Attachment: menu.png added

comment:9 Changed 3 months ago by rednose

Hi Ryan,

The fix works in princal, but the layout of the menus looks odd:

Is this intended ?

comment:10 Changed 3 months ago by Ryan J Ollos

See comment:7:

The CSS needs improvement. Patches welcome.

comment:11 Changed 3 months ago by Ryan J Ollos

If you are able to provide a patch, please make sure to provide a diff as described in trac:TracDev/SubmittingPatches.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.