Modify ↓

Opened 7 years ago

Closed 7 years ago

#13057 closed defect (fixed)

[Patch] Text input changes are not reflected to ticket

Reported by: snipsnipsnip@… Owned by: Ryan J Ollos
Priority: normal Component: GridModifyPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description

Hi, I upgraded to Trac 1.2 and noticed that editing <input type="text"> with GridModifyPlugin no longer work (i.e. changes are not reflected to the ticket). It looks like the jQuery upgrade broke the plugin. Replacing $(this).attr('value') with $(this).val() fixed the issue.

Attached is a minimal patch to gridmodifyplugin/trunk@16209​.

Attachments (1)

gridmodifyplugin.patch​ (656 bytes) - added by snipsnipsnip@… 7 years ago.
patch to GridModifyPlugin

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by snipsnipsnip@…

Attachment: gridmodifyplugin.patch​ added

patch to GridModifyPlugin

comment:1 Changed 7 years ago by Ryan J Ollos

Owner: changed from Björn Harrtell to Ryan J Ollos
Status: new → accepted

Thanks for the patch. It looks like there are a few other attr('value') -> val() replacements that could be made. I'll test and commit the changes.

comment:2 Changed 7 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 16210:

1.0.0dev: Use jQuery val method

Initial patch by snipsnipsnip@users.osdn.me.

Fixes #13057.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.