Modify

Opened 3 years ago

Last modified 3 months ago

#13079 accepted defect

Setting review deleting ticket owner

Reported by: Massimo Owned by: Ryan J Ollos
Priority: normal Component: CodeReviewerPlugin
Severity: critical Keywords:
Cc: Massimo Trac Release: 1.2

Description

Since Trac 1.2, setting a review to PASSED deletes the Owner of that ticket. Afterwards the Owner is set to "No owner". The review switch itself is listed in the history of the ticket as Changed on 21.02.2017 at 11:32:55 by (none).

Attachments (0)

Change History (17)

comment:1 Changed 3 years ago by Massimo

Summary: SettSetting review deleting ticket owner

comment:2 Changed 3 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: newaccepted

comment:3 Changed 2 years ago by Massimo

Are you able to reproduce this issue? It is breaking the main functionality of this plugin leaving tickets in an inconsistent state.

comment:4 Changed 2 years ago by Massimo

I guess this could be based on this config section that was working before Trac 1.2:

[codereviewer]
failed = owner={author}
passed = owner={author}
status_choices = rejected,open,passed

comment:5 Changed 2 years ago by Massimo

Any news on that? We can't use the review function in the meanwhile as it deletes the ticket owner. Chances that 1.2 -> 1.2.1 update will fix something about that?

comment:6 Changed 2 years ago by anonymous

Please provide your configuration ([codereviewer] section at least).

comment:7 Changed 2 years ago by Massimo

[codereviewer]
#failed = owner={author}
#passed = owner={author}
command = echo "Reviewed {author}" > /mnt/data/trac/projects/trac-ppp/review.dump
status_choices = rejected,open,passed

comment:8 in reply to:  6 Changed 2 years ago by Ryan J Ollos

Replying to anonymous:

Please provide your configuration ([codereviewer] section at least).

Did you look at comment:4?

comment:9 Changed 2 years ago by Ryan J Ollos

In 16566:

1.0dev: Fix empty reviewer name and sync error

Refs #13079.

comment:10 Changed 2 years ago by Ryan J Ollos

Please report back if the issue is resolved, however the plugin has no maintainer and I don't have time to fix every issue that arises with unmaintained plugins on trac-hacks.org, so I can't promise to that I'll be able to revisit it if it's not fixed.

comment:11 Changed 2 years ago by Massimo

Thanks for the bugfix. It seems that now the owner is not reset to "None" anymore, this one is solved. However the comment for the review still doesn't show the author of the review:

Changed on 09.05.2017 at 09:14:28 by (none)
Last edited 2 years ago by Massimo (previous) (diff)

comment:12 Changed 2 years ago by Ryan J Ollos

Status: acceptednew

comment:13 Changed 2 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

comment:14 Changed 3 months ago by Massimo

We upgraded to current stable Trac 1.2.3 and latest svn 1.0.0.dev0 of this plugin, but the reviewer is still logged as user (none). Any idea? Any alternative recommendation for a reviewer plugin doing reviews per change, not per line?

comment:15 Changed 3 months ago by Massimo

Cc: Massimo added

comment:16 Changed 3 months ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: newaccepted

Will try to look at this soon.

comment:17 Changed 3 months ago by Massimo

Ok, please let me know.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as accepted The owner will remain Ryan J Ollos.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.