Setting review deleting ticket owner

[Massimo]

Since Trac 1.2, setting a review to PASSED deletes the Owner of that ticket. Afterwards the Owner is set to "No owner". The review switch itself is listed in the history of the ticket as Changed on 21.02.2017 at 11:32:55 by (none).

[Massimo]

Are you able to reproduce this issue? It is breaking the main functionality of this plugin leaving tickets in an inconsistent state.

[Massimo]

I guess this could be based on this config section that was working before Trac 1.2:

[codereviewer]
failed = owner={author}
passed = owner={author}
status_choices = rejected,open,passed

[Massimo]

Any news on that? We can't use the review function in the meanwhile as it deletes the ticket owner. Chances that 1.2 -> 1.2.1 update will fix something about that?

[anonymous]

Please provide your configuration ([codereviewer] section at least).

[Massimo]

[codereviewer]
#failed = owner={author}
#passed = owner={author}
command = echo "Reviewed {author}" > /mnt/data/trac/projects/trac-ppp/review.dump
status_choices = rejected,open,passed

[Ryan J Ollos]

Replying to anonymous:

Please provide your configuration ([codereviewer] section at least).

Did you look at comment:4?

[Ryan J Ollos]

In 16566:

1.0dev: Fix empty reviewer name and sync error

Refs #13079.

[Ryan J Ollos]

Please report back if the issue is resolved, however the plugin has no maintainer and I don't have time to fix every issue that arises with unmaintained plugins on trac-hacks.org, so I can't promise to that I'll be able to revisit it if it's not fixed.

[Massimo]

Thanks for the bugfix. It seems that now the owner is not reset to "None" anymore, this one is solved. However the comment for the review still doesn't show the author of the review:

Changed on 09.05.2017 at 09:14:28 by (none)

[Massimo]

We upgraded to current stable Trac 1.2.3 and latest svn 1.0.0.dev0 of this plugin, but the reviewer is still logged as user (none). Any idea? Any alternative recommendation for a reviewer plugin doing reviews per change, not per line?

[Ryan J Ollos]

Will try to look at this soon.

[Massimo]

Ok, please let me know.

[Ryan J Ollos]

In 17726:

CodeReviewerPlugin 1.0.0dev: Fixed reviewer not used in ticket change entry

Refs #13079.

[Ryan J Ollos]

I hope that finally fixes it. Sorry for the long delay!