AttributeError: 'unicode' object has no attribute 'read'

[Ryan J Ollos]

I encountered two issues.

1. jupyter is required: documented in JupyterNotebookPlugin@3
2. AttributeError: 'unicode' object has no attribute 'read'

21:44:27 Trac[api] WARNING: HTML preview using JupyterNotebookRenderer with <RenderingContext <Resource u'wiki:PythonNotebook'> - <Resource u'wiki:PythonNotebook'> - <Resource u'wiki:PythonNotebook'>> failed: 
Traceback (most recent call last):
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/mimeview/api.py", line 814, in render
    rendered_content, filename, url)
  File "/Users/rjollos/Documents/Workspace/trac-dev/trac-hacks/jupyternotebookplugin/1.0/tracjupyternotebook/renderer.py", line 32, in render
    notebook = nbformat.reads(content.read(), as_version=4)
AttributeError: 'unicode' object has no attribute 'read'

[Ryan J Ollos]

The plugin is intended to be used in a WikiProcessor like this?

{{{#!ipynb

}}}

If so, the following change fixes the issue:

tracjupyternotebook/renderer.py

@@ -29 +29 @@
         return 0
 
     def render(self, context, mimetype, content, filename=None, rev=None):
-        notebook = nbformat.reads(content.read(), as_version=4)
+        notebook = nbformat.reads(content, as_version=4)
 
         html_exporter = nbconvert.HTMLExporter()
         html_exporter.template_file = 'basic'

[Ryan J Ollos]

In 16379:

TracJupyterNotebook 1.0: Add jupyter to installation requirements

Refs #13126.

[tkob-trac]

Thank you for the report. As a quick reply to your question:

Replying to Ryan J Ollos:

The plugin is intended to be used in a WikiProcessor like this?

{{{#!ipynb

}}}

This plugin is intended to be used in the repository browser to preview ipynb files and I don't think ipynb is useful as Wiki macro, since you usually don't type ipynb source directly (it is non-human-friendly JSON format).

[Ryan J Ollos]

That make sense. Thanks for clarifying.