Crash for ResourceNotFound after ticket deletion

[ntmlod]

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/trac/web/api.py", line 514, in send_error
    data, 'text/html')
  File "/usr/lib/python2.7/site-packages/trac/web/chrome.py", line 983, in render_template
    stream |= self._filter_stream(req, method, filename, stream, data)
  File "/usr/lib64/python2.7/site-packages/genshi/core.py", line 133, in __or__
    return Stream(_ensure(function(self)), serializer=self.serializer)
  File "/usr/lib/python2.7/site-packages/trac/web/chrome.py", line 1162, in inner
    data)
  File "build/bdist.linux-x86_64/egg/breadcrumbsnav/breadcrumbs.py", line 184, in filter_stream
    title = get_resource_summary(self.env, resource)
  File "/usr/lib/python2.7/site-packages/trac/resource.py", line 347, in get_resource_summary
    return get_resource_description(env, resource, 'summary')
  File "/usr/lib/python2.7/site-packages/trac/resource.py", line 333, in get_resource_description
    return manager.get_resource_description(resource, format, **kwargs)
  File "/usr/lib/python2.7/site-packages/trac/ticket/api.py", line 525, in get_resource_description
    ticket = Ticket(self.env, resource.id)
  File "/usr/lib/python2.7/site-packages/trac/ticket/model.py", line 82, in __init__
    self._fetch_ticket(tkt_id)
  File "/usr/lib/python2.7/site-packages/trac/ticket/model.py", line 121, in _fetch_ticket
    id=tkt_id), _("Invalid ticket number"))
ResourceNotFound: Ticket 1899 does not exist.

My raw fix

breadcrumbsnav/breadcrumbs.py

@@ -10 +10 @@
 from trac.config import IntOption, ListOption, Option
 from trac.env import IEnvironmentSetupParticipant
 from trac.resource import Resource, get_resource_shortname, \
-                          get_resource_summary
+                          get_resource_summary, ResourceNotFound
 from trac.web import IRequestFilter
 from trac.web.api import ITemplateStreamFilter
 from trac.web.chrome import ITemplateProvider, add_stylesheet
@@ -181 +181 @@
             resource = Resource(realm, resource_id)
 
             name = get_resource_shortname(self.env, resource)
-            title = get_resource_summary(self.env, resource)
-            link = req.href(realm, resource_id)
 
+            try:
+                title = get_resource_summary(self.env, resource)
+            except ResourceNotFound:
+                title = "Deleted"
+                pass
+    
+            link = req.href(realm, resource_id)
+
             first = ul == []
             li = tag.li(tag.a(title=title, href=link)(name))
             if first:

[Ryan J Ollos]

In 16589:

BreadCrumbsNav 0.3: Don't display non-existent resources

Based on a patch by ntmlod

Require Trac >= 1.0 and conform to PEP8.

Fixes #13178.

[Ryan J Ollos]

Since the Deleted doesn't provide any useful navigation, I thought it would be better to just skip missing resources. Let me know if you find any issues.

Thanks for the patch!