Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13180 closed defect (fixed)

Don't allow a select box in a ticket query

Reported by: roger.oberholtzer@… Owned by: Ryan J Ollos
Priority: normal Component: SumFieldsPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

When doing a ticket query, and the Batch Modify plugin is also present, the row containing the sum: information can be selected. This should not be the case because the row does not refer to a ticket. If the row is selected, one gets this error when doing the batch modify:

ValueError: invalid literal for int() with base 10: 'um:'

Deselecting the row makes the error go away. But I cannot see why it should be selectable in the first place.

Having the sum: row be selectable may also cause confusion in other contexts.

Attachments (2)

Screen Shot 2017-05-17 at 12.16.44.png (47.9 KB) - added by Ryan J Ollos 4 years ago.
Screen Shot 2017-05-17 at 12.22.19.png (47.4 KB) - added by Ryan J Ollos 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by Ryan J Ollos

Owner: changed from Cinc-th to Ryan J Ollos
Status: newaccepted

comment:2 Changed 4 years ago by Ryan J Ollos

In 16595:

2.0.0dev: Add sum row in a tfoot

Refs #13180.

comment:3 Changed 4 years ago by Ryan J Ollos

Proposed fix in trac:#12811. Table styling will also be improved with the proposed change for Trac 1.2.2.

Changed 4 years ago by Ryan J Ollos

Changed 4 years ago by Ryan J Ollos

comment:4 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

After r16595 the checkbox is added, but is not selected by the select all checkbox.

You can still explicitly select it, which would lead to the exception.

If anyone cares enough to improve this for Trac < 1.2.2, feel free to submit a patch. It's a cosmetic issue that will be resolved by upgrading to Trac 1.2.2 (when it's released). See trac:#12811 for example of no checkbox in the tfoot row, and improved styling.

comment:5 Changed 4 years ago by roger.oberholtzer@…

I have added this update. The Sum: row is now not selected by default.

But I see another thing that was not there previously (I am fairly certain). If the report is grouped by some variable, the first group does not have the Sum: row. All other ones do. And, the final group has 2 Sum: rows. One of which is the missing one from the first group.

comment:6 Changed 4 years ago by Ryan J Ollos

In 16600:

2.0.0dev: Don't add multiple tfoot per table

Refs #13180.

comment:7 Changed 4 years ago by Ryan J Ollos

Yeah, it doesn't work well. Thanks for testing and noticing.

I've proposed a different change in trac:#12811 that should fix the issue after installing r16600. If no issues are found with the proposed change it will be included in Trac 1.2.2. In the meantime, just be sure to deselect the Sum row before submitting a batch modify request.

comment:8 Changed 4 years ago by Ryan J Ollos

In 16603:

TracSumFields 2.0.0dev: Revise r16600 to fix column alignment

In Trac 1.2.2+ an empty cell will be added when the batch
modify column is added to the table, so that the columns
maintain alignment.

Refs #13180.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.