AttributeError: can't set attribute

[Ryan J Ollos]

How to Reproduce

While doing a GET operation on /zip/attachment/wiki/WikiStart/ArchiveViewer-0.1-py2.7.egg!/EGG-INFO/SOURCES.txt, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{'attachment': <Resource u'wiki:WikiStart, attachment:ArchiveViewer-0.1-py2.7.egg'>,
 'format': None,
 'path': u'!/EGG-INFO/SOURCES.txt'}

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0

System Information

Trac	1.2.2.dev0
Babel	2.4.0
Docutils	0.13.1
Genshi	0.7 (with speedups)
GIT	2.13.1
Pygments	2.2.0
pysqlite	2.6.0
Python	2.7.13 (default, Dec 18 2016, 07:03:39) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
pytz	2017.2
setuptools	35.0.2
SQLite	3.19.2
Subversion	1.9.5 (r1770682)
Textile	2.3.11
jQuery	1.11.3
jQuery UI	1.11.4
jQuery Timepicker	1.5.5

Enabled Plugins

ArchiveViewer

0.1

Interface Customization

Python Traceback

Traceback (most recent call last):
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/web/main.py", line 623, in _dispatch_request
    dispatcher.dispatch(req)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/web/main.py", line 239, in dispatch
    resp = chosen_handler.process_request(req)
  File "/Users/rjollos/Documents/Workspace/trac-dev/trac-hacks/archiveviewerplugin/1.0/archiveviewer/zip.py", line 245, in process_request
    attachment.resource = context.resource
AttributeError: can't set attribute

[Ryan J Ollos]

Attachment.resource is a property since Trac 1.1.4: ​trac:r13487.

On Trac 1.0-stable the parent resource is a link to the egg file:

Proposed fix:

archiveviewer/zip.py

@@ -242 +242 @@
                 fileobj, zipinfo.file_size, mime_type, name, rawurl,
                  annotations=['lineno'])
             if attachment:
-                attachment.resource = context.resource
+
+                try:
+                    attachment.resource = context.resource
+                except AttributeError:  # Trac >= 1.1.4
+                    class _ZipAttachment(Attachment):
+
+                        @property
+                        def resource(self):
+                            return Resource(self.parent_resource) \
+                                   .child(self.realm, self.filename)
+
+                        def __init__(self, attachment, resource):
+                            self.description = attachment.description
+                            self.size = attachment.size
+                            self.date = attachment.date
+                            self.author = attachment.author
+                            if hasattr(attachment, 'ipnr'):
+                                self.ipnr = attachment.ipnr
+                            self.filename = resource.id
+                            self.parent_realm = resource.parent.realm
+                            self.parent_id = resource.parent.id
+                            self.parent_resource = resource.parent
+
+                    attachment = _ZipAttachment(attachment, context.resource)
+
                 data = {'preview': preview,
-                    'attachment': attachment}
+                        'attachment': attachment}
                 return 'attachment.html', data, None
             elif browser:
                 path_links = get_path_links(req.href, reponame, path, rev)

[Ryan J Ollos]

In 16654:

TracArchiveViewer 0.2dev: Fix AttributeError with Trac 1.1.4+

Fixes #13206.