String Formating "%s" output in user creation error

[conloos@…]

Hi,

If i try to create a user account and the account isn't compatible with the regexp policy, an error message is shown. In this error message the string formatting field %s is displayed, not the username who should be created.

[Ryan J Ollos]

Providing the actual error message would be useful.

[Ryan J Ollos]

This appears to be an error in [12384/accountmanagerplugin/trunk/acct_mgr/register.py]. The message args are stored in msg_args, but nothing is done with them. I'm unsure why a noop translation marker needs to be used in this case. The following patch might be sufficient:

acct_mgr/register.py

@@ -313 +313 @@
             req.args.get('username', '').strip())
         if req.path_info != '/prefs' and self.username_regexp != '' and \
                 not re.match(self.username_regexp.strip(), username):
-            raise RegistrationError(N_(
-                "Username %s doesn't match local naming policy."),
-                tag.b(username)
-            )
+            raise RegistrationError(tag_(
+                "Username %(username)s doesn't match local naming policy.",
+                username=tag.b(username)
+            ))
 
         email = req.args.get('email', '').strip()
         if self.env.is_enabled(EmailCheck) and \

Similar changes likely need to be made elsewhere in the module.

[Ryan J Ollos]

In 16680:

TracAccountManager 0.5dev: Fix messages not interpolated

Fixes #13222.

[Jun Omae]

Since [16680], _("revoked") and _('pending') are passed to set_user_attribute(). Those localized revoked and pending would be stored in session_attribute.value column.

I consider we should localize the values when displaying on browser and console rather than storing localized values.

[Ryan J Ollos]

In 16720:

TracAccountManager 0.5dev: Don't store translated strings in session attributes

Fixes #13222.