Opened 7 years ago
Last modified 7 years ago
#13256 new task
Switch from yuku-t/jquery-textcomplete to yuku-t/textcomplete?
| Reported by: | Peter Suter | Owned by: | Peter Suter |
|---|---|---|---|
| Priority: | normal | Component: | WikiAutoCompletePlugin |
| Severity: | normal | Keywords: | |
| Cc: | Trac Release: |
Description
Currently this plugin use yuku-t/jquery-textcomplete, which is:
DEPRECATED: use yuku-t/textcomplete
Attachments (4)
Change History (8)
Changed 7 years ago by
| Attachment: | T13256_textcomplete.patch added |
|---|
comment:1 Changed 7 years ago by
Changed 7 years ago by
| Attachment: | T13256_textcomplete.1.patch added |
|---|
Changed 7 years ago by
| Attachment: | Screen Shot 2018-05-08 at 14.24.50.jpg added |
|---|
Changed 7 years ago by
| Attachment: | Screen Shot 2018-05-08 at 14.25.07.jpg added |
|---|
comment:2 Changed 7 years ago by
Upgraded to textcomplete 0.17.1 and added a few styling adjustments (T13256_textcomplete.1.patch).
The only issue I've found so far is that the dropdown no longer scrolls on key up/down.
Example: On keydown the active item is highlighted until the bottom of the list of visible items, but the visible items don't update:
Scrolling with the mouse updates the list of visible items:
comment:3 follow-up: 4 Changed 7 years ago by
The scrolling issue is maybe not a blocking issue.
Personally I don't like that moving the cursor doesn't update (or open or close) the menu. Also losing focus doesn't close the menu.
comment:4 Changed 7 years ago by
Replying to Peter Suter:
Personally I don't like that moving the cursor doesn't update (or open or close) the menu. Also losing focus doesn't close the menu.
Should we implement the destroy event?
Attempt to switch in attached patch.
Not sure what to do with
optionsandTextareaAdapter, or if these are not needed anymore.