Modify

Opened 7 years ago

Last modified 6 years ago

#13256 new task

Switch from yuku-t/jquery-textcomplete to yuku-t/textcomplete?

Reported by: Peter Suter Owned by: Peter Suter
Priority: normal Component: WikiAutoCompletePlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Currently this plugin use yuku-t/jquery-textcomplete, which is:

DEPRECATED: use yuku-t/textcomplete

Attachments (4)

T13256_textcomplete.patch (53.0 KB) - added by Peter Suter 7 years ago.
T13256_textcomplete.1.patch (52.6 KB) - added by Ryan J Ollos 6 years ago.
Screen Shot 2018-05-08 at 14.24.50.jpg (36.5 KB) - added by Ryan J Ollos 6 years ago.
Screen Shot 2018-05-08 at 14.25.07.jpg (42.6 KB) - added by Ryan J Ollos 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by Peter Suter

Attachment: T13256_textcomplete.patch added

comment:1 Changed 7 years ago by Peter Suter

Attempt to switch in attached patch.

Not sure what to do with options and TextareaAdapter, or if these are not needed anymore.

Changed 6 years ago by Ryan J Ollos

Attachment: T13256_textcomplete.1.patch added

Changed 6 years ago by Ryan J Ollos

Changed 6 years ago by Ryan J Ollos

comment:2 Changed 6 years ago by Ryan J Ollos

Upgraded to textcomplete 0.17.1 and added a few styling adjustments (T13256_textcomplete.1.patch).

The only issue I've found so far is that the dropdown no longer scrolls on key up/down.

Example: On keydown the active item is highlighted until the bottom of the list of visible items, but the visible items don't update:

Scrolling with the mouse updates the list of visible items:

comment:3 Changed 6 years ago by Peter Suter

The scrolling issue is maybe not a blocking issue.

Personally I don't like that moving the cursor doesn't update (or open or close) the menu. Also losing focus doesn't close the menu.

comment:4 in reply to:  3 Changed 6 years ago by Ryan J Ollos

Replying to Peter Suter:

Personally I don't like that moving the cursor doesn't update (or open or close) the menu. Also losing focus doesn't close the menu.

Should we implement the destroy event?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Peter Suter.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.