Modify

Opened 17 years ago

Closed 17 years ago

#1326 closed defect (fixed)

unrecoverable error when "blocking" value is invalid

Reported by: phpxcache Owned by: Noah Kantrowitz
Priority: high Component: MasterTicketsPlugin
Severity: blocker Keywords:
Cc: pmocek-edgewall-tracwiki@… Trac Release: 0.10

Description

"1,2,3" works "1 2 3" give backtrace, and u get no chance to fix the ticket untill mastertickets id disabled

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 387, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 239, in dispatch
    template, content_type = self._post_process_request(req,
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 269, in _post_process_request
    content_type)
  File "build/bdist.linux-i686/egg/mastertickets/web_ui.py", line 59, in post_process_request
  File "build/bdist.linux-i686/egg/mastertickets/util.py", line 24, in linkify_ids
  File "/usr/lib/python2.4/site-packages/trac/ticket/model.py", line 40, in __init__
    self._fetch_ticket(tkt_id, db)
  File "/usr/lib/python2.4/site-packages/trac/ticket/model.py", line 86, in _fetch_ticket
    raise TracError('Ticket %d does not exist.' % tkt_id,
TypeError: int argument required

Attachments (0)

Change History (5)

comment:1 Changed 17 years ago by xurizaemon

Confirmed here too. If you enter ticket ids which aren't comma-separated, you will get this grumpy error message.

Quick fix is to edit the DB directly, and do this (where 316 is the ticket with a bung blocking entry):

$ sqlite3 /my/trac/db/trac.db
sqlite> delete from ticket_custom where name = 'blocking' and ticket = 316 ;

comment:2 Changed 17 years ago by anonymous

I love this plugin and am hoping this issue is resolved soon so I can use it again. Thanks!

comment:3 Changed 17 years ago by Noah Kantrowitz

Resolution: fixed
Status: newclosed

This was fixed in changeset:5836.

comment:4 Changed 17 years ago by pmocek-edgewall-tracwiki@…

Cc: pmocek-edgewall-tracwiki@… added; anonymous removed
Resolution: fixed
Status: closedreopened

I made the same change as in changeset:5836 in my Trac 0.10 installation (edited model.py & re-generated model.pyc), and found that when I attempt to view the offending ticket, the same stack trace is shown (with the exception that the next-to-last line shows "Ticket %s does not exist" instead of "Ticket %d does not exist"):

comment:5 Changed 17 years ago by Noah Kantrowitz

Resolution: fixed
Status: reopenedclosed

I do not have the bandwidth to support both 0.10 and 0.11. 0.10 will no longer be supported with respect to this plugin.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Noah Kantrowitz.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.