Modify

Opened 15 months ago

Closed 11 months ago

Last modified 11 months ago

#13270 closed defect (fixed)

Missed td with select in foot of query table

Reported by: anonymous Owned by: Russ Tyndall
Priority: low Component: TimingAndEstimationPlugin
Severity: trivial Keywords:
Cc: Trac Release: 1.2

Description

Environment:

In timingandestimationplugin/htdocs/query.js missed empty td in footer, where summary of total hours.

  • jquery.js

    diff --git a/jquery.js b/jquery.js
    index b262d5d..0619ed2 100644
    a b $(document).ready(function(){ 
    99    if(tbody.has('tr.even').length == 0) return true;
    1010    var tfoot = $('<tbody class="foot"></tbody>');
    1111    var totalsRow = $('tr:first-child',tbody).clone();
     12    totalsRow.prepend($('<td></td>'));
    1213    tfoot.append(totalsRow);
    1314
    1415    // Build footer row

Attachments (1)

1 missed td.png (17.8 KB) - added by anonymous 15 months ago.

Download all attachments as: .zip

Change History (10)

Changed 15 months ago by anonymous

Attachment: 1 missed td.png added

comment:1 Changed 15 months ago by anonymous

Last edited 15 months ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 15 months ago by anonymous

I think, it's only for users with TICKET_BATCH_MODIFY permission.

comment:3 Changed 15 months ago by anonymous

For fix it, just need set tbody class to trac-query-summary:

var tfoot = $('<tbody class="trac-query-summary"></tbody>');

comment:4 Changed 15 months ago by Ryan J Ollos

trac:#12811 might be relevant.

comment:5 Changed 11 months ago by stefan

any update on this? I guess the first td element (<td class="sel">...</td>) lacks on the last table footer line.

Also I cannot figure out where to fix this? Changes on query.js file, talking above, are not working.

I have tested on file located at: wiki/eggs/timingandestimationplugin-1.5.0-py2.7.egg-tmp/timingandestimationplugin/htdocs/query.js

Last edited 11 months ago by Ryan J Ollos (previous) (diff)

comment:6 in reply to:  5 Changed 11 months ago by Ryan J Ollos

Replying to stefan:

I have tested on file located at: wiki/eggs/timingandestimationplugin-1.5.0-py2.7.egg-tmp/timingandestimationplugin/htdocs/query.js

You should check out the source, edit the source and recreate the egg. See TracPlugins#InstallingaTracplugin.

comment:7 Changed 11 months ago by Russ Tyndall

In 17019:

Fix extra footer TD by waiting a little before totalling. re #13270

comment:8 Changed 11 months ago by Russ Tyndall

Alright, I think its fixed. I rewrote the code and it was still doing it. I ended up just needing to let other JS first and defer this for an .125 sec

Sorry for the delay.

comment:9 Changed 11 months ago by Russ Tyndall

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Russ Tyndall.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.