Missed td with select in foot of query table

[anonymous]

Environment:

• Trac 1.2.2
• TimingAndEstimationPlugin-1.5.0b

In timingandestimationplugin/htdocs/query.js missed empty td in footer, where summary of total hours.

jquery.js

@@ -9 +9 @@
     if(tbody.has('tr.even').length == 0) return true;
     var tfoot = $('<tbody class="foot"></tbody>');
     var totalsRow = $('tr:first-child',tbody).clone();
+    totalsRow.prepend($('<td></td>'));
     tfoot.append(totalsRow);
 
     // Build footer row

[anonymous]

I think, it's only for users with TICKET_BATCH_MODIFY permission.

[anonymous]

For fix it, just need set tbody class to trac-query-summary:

var tfoot = $('<tbody class="trac-query-summary"></tbody>');

[Ryan J Ollos]

​trac:#12811 might be relevant.

[stefan]

any update on this? I guess the first td element (<td class="sel">...</td>) lacks on the last table footer line.

Also I cannot figure out where to fix this? Changes on query.js file, talking above, are not working.

I have tested on file located at: wiki/eggs/timingandestimationplugin-1.5.0-py2.7.egg-tmp/timingandestimationplugin/htdocs/query.js

[Ryan J Ollos]

Replying to stefan:

I have tested on file located at: wiki/eggs/timingandestimationplugin-1.5.0-py2.7.egg-tmp/timingandestimationplugin/htdocs/query.js

You should check out the source, edit the source and recreate the egg. See TracPlugins#InstallingaTracplugin.

[Russ Tyndall]

In 17019:

Fix extra footer TD by waiting a little before totalling. re #13270

[Russ Tyndall]

Alright, I think its fixed. I rewrote the code and it was still doing it. I ended up just needing to let other JS first and defer this for an .125 sec

Sorry for the delay.