Enable styling of ticket comments links

[ntmlod]

I'm not sure if it's an defect or an enhancement but it would useful if the ticket comment links can be highlighted in the same way as ticket links.

[Ryan J Ollos]

In 16867:

ContextChrome 0.4: Decorate ticket comment links

Fixes #13290.

[ntmlod]

Thanks for the work but I didn't see the changes with the previous revision, perhaps I misunderstood what I wanted.

Previously on our timeline view, the ticket links were already recognized and highlighted in <dd> tags (from commit messages) but my proposal was to have the same in the <dt> tags of tickets.

And at this time the ticket links are still not selected from <dt>.

[Ryan J Ollos]

I added highlighting of 10 through 12, the comment:1:ticket:1 form:

How about a set of rules like the following?:

.timeline dt.newticket a em[title~="defect:"],
.timeline dt.editedticket a em[title~="defect:"] {
    background-color: #f5deb3; /* wheat */
}
.timeline dt.newticket a em[title~="enhancement:"],
.timeline dt.editedticket a em[title~="enhancement:"] {
    background-color: #87ceeb; /* sky blue */
}
.timeline dt.newticket a em[title~="task:"],
.timeline dt.editedticket a em[title~="task:"] {
    background-color: #ffd700; /* gold */
}

The rules yield:

[ntmlod]

I forgot to add that I used it to highlight the priority of the tickets. I can't enable it with CSS as there is no clue in the HTML code.

I lack the understanding of Trac system in general, I can't figure out why the plugin can detect the ticket link in <dd> and not <dt>. It is related to isinstance detection method ?

[Ryan J Ollos]

The <dd> content is handled by the wiki formatter. The formatting happens in the ​IWikiSyntaxProvider implementation, which ContextChromePlugin monkey-patches.

The timeline event is rendered by ​ITimelineEventProvider. render_timeline_event. I think that method would also needed to be monkey-patched. I'm not sure if/when I will have time to do that, but created #13299 to cover the request.

[ntmlod]

Thanks for the explanation.
I had identified this part of the code was a kind of copy of ticket API but I wasn't aware of the other side of the problem.

I hope to have some time to look at it, at some point I have to get into the code to try doing it by myself.

[Ryan J Ollos]

Let me know if you have any questions about setting up the dev environment.