spurious multiple space characters

[c.feige@…]

It can happen that the TracKeywordsPlugin inserts multiple space characters when clicking multiple times on the same keyword.

I have tested this plugin (TracKeywordsPlugin 0.3dev-r0 / revision r16858) with TRAC 1.0.4.

Reproduce

1. click first keyword to insert
2. click second keyword to insert
3. click second keyword to removed
4. repeat clicking on second keyword to insert / removed.

Each (repeated) remove operation leaves one extra space character in the keyword field. These spaces accumulate more and more.

Patch

I have modified the last line of the addTag JS-function and improved the whitespace cleanup. Previously it was only one Regex (el.value = newval.replace(/^\s+/, '');).

Improved version:

function addTag(w) {
    var el = document.getElementById(field_id);
    var orig = el.value;
    var newval = orig.replace(new RegExp('\\b' + w + '\\b'), '');
    var link = document.getElementById('add_' + w);
    if (orig != newval) {
        // remove tag.
        if(link) link.className = '';
    } else {
        newval = orig + (orig ? ' ' : '') + w;
        if(link) link.className = 'sel';
    }
    /*BUGFIX below this line: */
    newval = newval.replace(/^\s+/, '');/*remove leading whitespace*/
    newval = newval.replace(/\s+$/, '');/*remove trailing whitespace*/
    newval = newval.replace(/\s{2,}/, ' ');/*remove multiple whitespace*/
    el.value = newval;
}

Thanks Clemens

[Ryan J Ollos]

Please consider providing a patch file in the future, to ease review (​TracDev/SubmittingPatches).

[Ryan J Ollos]

In 16865:

TracKeywordsPlugin 0.3dev: Strip trailing whitespace

Fixes #13296.