Opened 7 years ago
Closed 7 years ago
#13381 closed enhancement (fixed)
Patch for 1.3.2+ Compatability.
Reported by: | Jonathan Laufersweiler | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Component: | MasterTicketsPlugin |
Severity: | normal | Keywords: | patch |
Cc: | Trac Release: | 1.3 |
Description (last modified by )
Change to api.py to work with current update_environment api and change from time_changed to changetime..
I've been running this successfully with 1.3.2 for several weeks.
I tried it briefly with 1.3.3dev, and while nothing immediately exploded, I haven't spent nearly as much time there.
Attachments (3)
Change History (10)
Changed 7 years ago by
Attachment: | Trac_1.3.2.compatability.diff added |
---|
Changed 7 years ago by
Attachment: | 0001-Trac-1.32-Compatability.patch added |
---|
comment:1 Changed 7 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 7 years ago by
Type: | defect → enhancement |
---|
comment:3 Changed 7 years ago by
comment:4 Changed 7 years ago by
Good call on the db=None
, I've been doing similar on request handlers that took content_type as an argument and then returned it, but now need to return None. I'll get an update on here later today.
More broadly, what is the intended posture WRT backwards compatibility as we move to 1.4 & beyond? I had been imagining all but the simplest plugins would split into genshi and jinja2 branches in the near future, with only the latter being migrated to Python 3 thereafter. Is that accurate, or is the intention to increasingly add in-module version-responsive logic to maintain a single branch?
Changed 7 years ago by
Attachment: | Trac_1.3.2_plus_legacy_compatability.diff added |
---|
Adds legacy Trac support to previous changes.
comment:5 Changed 7 years ago by
Latest diff above for legacy Trac compatability alongside current:
- Added db=None term to upgrade functions
- Wrapped links.save with try except to fail over to tkt.time_changed.
comment:6 Changed 7 years ago by
Status: | new → accepted |
---|
Thanks. We can use
db=None
for backward compatibility. No need to submit with both thediff
andpatch
extension. Either is fine. See SubmittingPatches.