Modify

Opened 8 months ago

Closed 8 months ago

#13381 closed enhancement (fixed)

Patch for 1.3.2+ Compatability.

Reported by: Jonathan Laufersweiler Owned by: Ryan J Ollos
Priority: normal Component: MasterTicketsPlugin
Severity: normal Keywords: patch
Cc: Trac Release: 1.3

Description (last modified by Jonathan Laufersweiler)

Change to api.py to work with current update_environment api and change from time_changed to changetime..

I've been running this successfully with 1.3.2 for several weeks.

I tried it briefly with 1.3.3dev, and while nothing immediately exploded, I haven't spent nearly as much time there.

Attachments (3)

Trac_1.3.2.compatability.diff (1.1 KB) - added by Jonathan Laufersweiler 8 months ago.
0001-Trac-1.32-Compatability.patch (1.7 KB) - added by Jonathan Laufersweiler 8 months ago.
Trac_1.3.2_plus_legacy_compatability.diff (1.5 KB) - added by Jonathan Laufersweiler 8 months ago.
Adds legacy Trac support to previous changes.

Download all attachments as: .zip

Change History (10)

Changed 8 months ago by Jonathan Laufersweiler

Changed 8 months ago by Jonathan Laufersweiler

comment:1 Changed 8 months ago by Jonathan Laufersweiler

Description: modified (diff)

comment:2 Changed 8 months ago by Jonathan Laufersweiler

Type: defectenhancement

comment:3 Changed 8 months ago by Ryan J Ollos

Thanks. We can use db=None for backward compatibility. No need to submit with both the diff and patch extension. Either is fine. See SubmittingPatches.

comment:4 Changed 8 months ago by Jonathan Laufersweiler

Good call on the db=None, I've been doing similar on request handlers that took content_type as an argument and then returned it, but now need to return None. I'll get an update on here later today.

More broadly, what is the intended posture WRT backwards compatibility as we move to 1.4 & beyond? I had been imagining all but the simplest plugins would split into genshi and jinja2 branches in the near future, with only the latter being migrated to Python 3 thereafter. Is that accurate, or is the intention to increasingly add in-module version-responsive logic to maintain a single branch?

Changed 8 months ago by Jonathan Laufersweiler

Adds legacy Trac support to previous changes.

comment:5 Changed 8 months ago by Jonathan Laufersweiler

Latest diff above for legacy Trac compatability alongside current:

  • Added db=None term to upgrade functions
  • Wrapped links.save with try except to fail over to tkt.time_changed.

comment:6 Changed 8 months ago by Ryan J Ollos

Status: newaccepted

comment:7 Changed 8 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 17048:

TracMasterTickets 4.0.2dev: Add compatibility with Trac 1.3dev

Fixes #13381.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.