Modify

Opened 15 months ago

Last modified 15 months ago

#13404 assigned defect

Deletion of Filters not possible

Reported by: Andreas Owned by: EmeCas
Priority: normal Component: TracHoursPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description

After adding a filter, it is not possible to delete it by clicking on the (-) button (see Screenshot) - nothing happens

Attachments (1)

Delete Filter.jpg (59.0 KB) - added by Andreas 15 months ago.

Download all attachments as: .zip

Change History (7)

Changed 15 months ago by Andreas

Attachment: Delete Filter.jpg added

comment:1 Changed 15 months ago by Ryan J Ollos

Owner: changed from EmeCas to Ryan J Ollos
Status: newaccepted

hours_timeline.html is a copy/modify of query.html in Trac. The hours_timeline.html template should be updated against the latest version of query.html.

For now, I'll make the minimal changes needed to fix filter deletion.

Last edited 15 months ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 15 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 17100:

TracHours 0.7.3dev: Fix filter cannot be deleted

Fixes #13404.

comment:3 Changed 15 months ago by Andreas

Resolution: fixed
Status: closedreopened

Sorry if I got you wrong, but do you want me to copy&paste the content from query.html from Trac to hours_timeline.html?

I just did a test with the latest version, and now the filter doesn't work anymore: I can add the filter, select an entry and after clicking on update, the filter disappears and nothing happens.

After adding the filter (before clicking on Update), it is also not possible to delete the filter with a click on the (-) button - nothing happens, like before.

Thank you for checking it!

comment:4 in reply to:  3 Changed 15 months ago by Ryan J Ollos

Replying to Andreas:

Sorry if I got you wrong, but do you want me to copy&paste the content from query.html from Trac to hours_timeline.html?

Someone that understands the code needs to selectively merge changes. The hours_timeline.html view depends on query.js from Trac.

I don't have any more time to work on this. I'll revert r17100.

comment:5 Changed 15 months ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to EmeCas
Status: reopenedassigned

comment:6 Changed 15 months ago by Ryan J Ollos

In 17101:

TracHours 0.7.3dev: Revert r17100

Refs #13404.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain EmeCas.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.