ticketlog sync :: DataError: (1264, "Out of range value for column 'ticket' at row 1")

[Rochi]

There is a bug if I run:

trac-admin $env ticketlog sync

DataError: (1264, "Out of range value for column 'ticket' at row 1")

This is because the ticket number sometimes matches invalid numbers.

I fixed it with:

web_ui.py

@@ -27 +27 @@
 from trac.util.text import shorten_line
 from trac.util.translation import domain_functions
 from tracopt.ticket.commit_updater import CommitTicketUpdater
+from trac.util.text import exception_to_unicode
 
 gettext, _, tag_, N_, add_domain = \
     domain_functions('ticketlog', 'gettext', '_', 'tag_', 'N_', 'add_domain')
@@ -154 +155 @@
 
     def _insert_revision(self, rid, rev, message):
         tickets = self._parse_message(message)
-        with self.env.db_transaction as db:
-            for tid in tickets:
-                db("""
-                    INSERT INTO ticket_revision (ticket,repos,rev)
-                    VALUES (%s,%s,%s)
-                    """, (tid, rid, rev))
+        try:
+            with self.env.db_transaction as db:
+                for tid in tickets:
+                    if tid <= 2147483647:
+                        db("""
+                            INSERT INTO ticket_revision (ticket,repos,rev)
+                            VALUES (%s,%s,%s)
+                            """, (tid, rid, rev))
+                    else:
+                        self.log.error("ticketlog::sync:Ticket #%s is not a valid ticket number!", tid)
+        except Exception as e:
+            self.log.error("Unexpected error while processing ticket "
+                           "#%s: %s", tid, exception_to_unicode(e))
 
     def _get_ticket_revisions(self, req, ticket_id):
         revisions = []

[Rochi]

Patch

[Ryan J Ollos]

In 17251:

TracTicketChangelog 1.2.0dev: Don't fail on exception when syncing the repository

Fixes #13461.

[Rochi]

Thx for fixing.