error: UID command error: BAD ['Error in IMAP command UID SEARCH: Invalid search date parameter

[anonymous]

2018-10-16 15:00:03,476 Trac[console] ERROR: Exception in trac-admin command: u"mailarchive fetch 'imap.example.com 'archive@example.com' EXAMPLE
Traceback (most recent call last):
  File "build\bdist.win32\egg\trac\admin\console.py", line 83, in onecmd
    rv = cmd.Cmd.onecmd(self, line) or 0
  File "C:\Python27\Lib\cmd.py", line 220, in onecmd
    return self.default(line)
  File "build\bdist.win32\egg\trac\admin\console.py", line 252, in default
    return self.cmd_mgr.execute_command(*args)
  File "build\bdist.win32\egg\trac\admin\api.py", line 135, in execute_command
    return f(*fargs)
  File "build\bdist.win32\egg\mailarchive\admin.py", line 34, in _do_fetch
    typ, data = imap_conn.uid('search', None, '(OR UNSEEN (SINCE %s))' % (yesterday,))
  File "C:\Python27\Lib\imaplib.py", line 772, in uid
    typ, dat = self._simple_command(name, command, *args)
  File "C:\Python27\Lib\imaplib.py", line 1087, in _simple_command
    return self._command_complete(name, self._command(name, *args))
  File "C:\Python27\Lib\imaplib.py", line 917, in _command_complete
    raise self.error('%s command error: %s %s' % (name, typ, data))
error: UID command error: BAD ['Error in IMAP command UID SEARCH: Invalid search date parameter (0.001 + 0.000 secs).']

[anonymous]

I get this since 2018-10-02 00:00. Before that it worked.

[anonymous]

Somehow the locale must have changed and it's not creating a localized yesterday value.

[Jun Omae]

The issue seems to be caused by %b in strftime with non-English locale.

Also, I noticed another issue which exception_to_unicode and _ are not imported.

mailarchiveplugin/trunk/mailarchive/admin.py

@@ -6 +6 @@
 
 from trac.admin import IAdminCommandProvider
 from trac.attachment import Attachment
+from trac.core import Component, TracError, implements
 from trac.db.api import DatabaseManager
-from trac.core import *
 from trac.env import IEnvironmentSetupParticipant
+from trac.util.text import exception_to_unicode
+from trac.util.translation import _
 
 from mailarchive.model import ArchivedMail, SCHEMA, normalized_filename
 
@@ -35 +37 @@
         imap_conn.select()
 
         # Search for mails since yesterday
-        yesterday = (datetime.date.today() - datetime.timedelta(1)).strftime("%d-%b-%Y")
-        typ, data = imap_conn.uid('search', None, '(OR UNSEEN (SINCE %s))' % (yesterday,))
+        yesterday = _imap_date_text(datetime.date.today() -
+                                    datetime.timedelta(1))
+        typ, data = imap_conn.uid('search', None,
+                                  '(OR UNSEEN (SINCE %s))' % yesterday)
         for uid in data[0].split():
 
             # No duplicates
@@ -122 +126 @@
             dbm.set_database_version(PLUGIN_VERSION, PLUGIN_NAME)
         else:
             dbm.upgrade(PLUGIN_VERSION, PLUGIN_NAME, 'mailarchive.upgrades')
+
+
+def _imap_date_text(dt):
+    months = ('Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep',
+              'Oct', 'Nov', 'Dec')
+    return '%02d-%s-%04d' % (dt.day, months[dt.month - 1], dt.year)

[lucid]

In 17291:

MailArchivePlugin: Always use IMAP RFC compatible month names, independent of locale.
(see #13492)

[lucid]

Replying to Jun Omae:

The issue seems to be caused by %b in strftime with non-English locale.

Oh, I didn't notice your patch. It looks like we came to similar conclusions.

Also, I noticed another issue which exception_to_unicode and _ are not imported.

Thank you, I will fix it.

[lucid]

In 17292:

MailArchivePlugin: Fix imports.
(see #13492)