Modify

Opened 7 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#13531 closed defect (fixed)

AccountManager SvnServePasswordStore doesn't adhere correctly to the IPasswordStore store API.

Reported by: Mat Cross Owned by: Mat Cross
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description (last modified by Ryan J Ollos)

Updating from 0.4.4 to 0.5.0 (Trac 1.2.3), registering new users to an svnserve store always results in error message Password for user foo existed, couldn't create and the user/pass line still being added to the store file.

One can see in the svnserve.py source that set_password always returns None. On further inspection the implementation of delete_user looks incorrect too.

Attachments (1)

my.diff (6.1 KB) - added by Mat Cross 7 weeks ago.
Patch for a proposed fix (against trunk), including a test suite.

Download all attachments as: .zip

Change History (6)

Changed 7 weeks ago by Mat Cross

Attachment: my.diff added

Patch for a proposed fix (against trunk), including a test suite.

comment:1 Changed 7 weeks ago by Ryan J Ollos

Status: newaccepted

comment:2 Changed 5 weeks ago by Ryan J Ollos

Description: modified (diff)

Thanks for the patch.

comment:3 Changed 5 weeks ago by Ryan J Ollos

In 17339:

TracAccountManager 0.5.1dev: Fix error registering new users with svnserve

Refs #13531.

comment:4 Changed 5 weeks ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

comment:5 Changed 5 weeks ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to Mat Cross

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Mat Cross.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.