Modify

Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#13579 closed defect (fixed)

missing comma in MIME_TYPES makes Graphviz render blocks that it should not

Reported by: ebouaziz@… Owned by: ebouaziz@…
Priority: normal Component: GraphvizPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description

on line 193, MIME_TYPES = ('application/graphviz') makes MIME_TYPES a string instead of a tuple.

This makes Graphviz's get_quality_ratio() return 2 and be selected to render a block that has for example the #!c shebang. This will fail and render dot's error message in a red rectangle.

fix: MIME_TYPES = ('application/graphviz',)

Attachments (0)

Change History (3)

comment:1 Changed 3 months ago by Ryan J Ollos

In 17422:

1.0.0.8dev: Fix incorrect application of graphviz renderer

Change is merged to 1.0.0.9dev (1.2 branch) and
1.3.0.1dev (trunk).

Fix by ebouaziz@….

Refs #13579.

Last edited 2 months ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 3 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

comment:3 Changed 3 months ago by Ryan J Ollos

Owner: changed from Christian Boos to ebouaziz@…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ebouaziz@….
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.