Modify

Opened 5 years ago

Closed 5 years ago

#13613 closed defect (wontfix)

Breaks trac due to deprecated templating engine

Reported by: ralph.phd@… Owned by:
Priority: normal Component: BlackMagicTicketTweaksPlugin
Severity: blocker Keywords:
Cc: Trac Release: 1.4

Description

Super useful plugin (used it for years), but unfortunately no longer compatible since the switch to the new templating engine. You'll see the following message during load:

Trac[chrome] WARNING: Component BlackMagicTicketTweaks relies on deprecated Genshi stream filtering

And it will break the functionality of other plugins. First saw this due to the MasterTicketsPlugin no longer displaying click-through links, and confirmed via log messages.

Attachments (0)

Change History (7)

comment:1 Changed 5 years ago by Ryan J Ollos

This plugin will likely need to be deprecated because it depends on ITemplateStreamFilter for nearly all of the features. For an alternative, take a look at DynamicFieldsPlugin, and let us know if there are behaviors that can't be replicated with that plugin.

comment:2 Changed 5 years ago by ralph.phd@…

Thanks for the quick reply! The plugin you suggested was a good start. In the end I settled on 3 pieces to suit my needs (replacing both BlackMagic and TicketValidator plugins which both don't play nice with v1.4). Listing below in case others find this helpful:

  1. DynamicFieldsPlugin - for client-side validation / auto-complete of ticket forms on edit
  1. KeepInterfaceSimplePlugin - for server-side validation / auto-fill on ticket state change
  1. /p-env/templates/site-footer.html - placing custom jQuery in here to disable editing of fields we set via an algorithm, implemented as a server script that runs on a crond schedule. Like this:
<script>
   // used to disable editing of fields set by the priority algorithm
   $('input#field-rank').attr('disabled', 'disabled'); 
   $('select#field-priority').attr('disabled', 'disabled'); 
</script>

All good now :).

comment:3 in reply to:  2 ; Changed 5 years ago by Ryan J Ollos

Replying to ralph.phd@…:

Thanks for the quick reply! The plugin you suggested was a good start. In the end I settled on 3 pieces to suit my needs (replacing both BlackMagic and TicketValidator plugins which both don't play nice with v1.4).

Were you using TracTicketValidatorPlugin or TicketValidatorPlugin?

Neither uses ITemplateStreamFilter, so they should work with Trac 1.4, though there could be other issues that need to be fixed. Do you recall the error?

comment:4 in reply to:  3 Changed 5 years ago by anonymous

Were you using TracTicketValidatorPlugin or TicketValidatorPlugin?

Neither uses ITemplateStreamFilter, so they should work with Trac 1.4, though there could be other issues that need to be fixed. Do you recall the error?

TicketValidatorPlugin, looking at my notes you're right there was no error; it just listed as abandoned / unmaintained, so I decided to go with the replacement instead.

comment:5 Changed 5 years ago by Ryan J Ollos

In 17511:

0.2dev: Make compatible with Trac 1.4

Refs #13613.

comment:6 Changed 5 years ago by Ryan J Ollos

In 17512:

0.2dev: Keep compatible with Trac < 1.4

Refs #13613.

comment:7 Changed 5 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

This plugin is deprecated in Trac 1.4 and later. See migration tips on BlackMagicTicketTweaksPlugin page.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.