Modify

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#13624 closed defect (fixed)

DepGraph no longer truncates irrelevant links

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: MasterTicketsPlugin
Severity: normal Keywords: depgraph
Cc: ralph.phd@… Trac Release: 1.4

Description

First of all: this plugin is incredibly useful; I've used it over the last 4 years to run project management for an entire company, with offices in two countries. Many thanks for creating it!

I recently started a new install with Trac v1.4. The plugin still works fine in terms of creating dependencies, etc. but DepGraphs now always render the complete tree (previously they were truncated to relevant tickets with pruned branches showing in gray). See comparison image below.

Any ideas? As the tree grows bigger, it's becoming a problem.

Attachments (1)

trees.jpg (49.3 KB) - added by ralph.phd@… 8 months ago.

Download all attachments as: .zip

Change History (11)

Changed 8 months ago by ralph.phd@…

Attachment: trees.jpg added

comment:1 Changed 8 months ago by ralph.phd@…

Cc: ralph.phd@… added

comment:2 Changed 8 months ago by anonymous

What is your trac.ini config? r12924 added this option:

[mastertickets]
full_graph = false

comment:3 in reply to:  2 Changed 8 months ago by ralph.phd@…

That was a good idea. My ini settings are:

[mastertickets]
acceptable_formats = png,cmapx
closed_color = green
closed_text = Done
dot_path = dot
full_graph = disabled
graph_direction = TD
gs_path = gs
highlight_target = enabled
opened_color = red
opened_text = ToDo
show_key = disabled
use_gs = disabled

so should be correct, but I did notice that it appears to ignore the show_key setting as well - the legend shows regardless of what value I use. I tried both "false" and "disabled" but no joy. When I change closed_text it does update the graph though, so it is reading the ini file. There's nothing in the log files other than a warning to upgrade prior to v1.6 since the plugin still uses the Genshi template.

Replying to anonymous:

What is your trac.ini config? r12924 added this option:

[mastertickets]
full_graph = false

comment:4 Changed 8 months ago by ralph.phd@…

After some more experimenting, I figured out that in order for a boolean parameter in [mastertickets]to be considered false, it has to be unset (blank). Setting is to "false" or "disabled" still is handled as enabled. So the fix was:

[mastertickets]
acceptable_formats = png,cmapx
closed_color = #00ff33
closed_text = Done
dot_path = /usr/bin/dot
full_graph = 
graph_direction = TD
gs_path = /usr/bin/gs
opened_color = #fbffeb
opened_text = ToDo
show_key = 
use_gs = 
highlight_target = enabled

comment:5 Changed 8 months ago by anonymous

r12924 should have used BoolOption instead of an Option for show_key, highlight_target and full_graph.

comment:6 Changed 8 months ago by Ryan J Ollos

In 17542:

TracMasterTickets 4.0.3: Use correct option type

Refs #13624.

comment:7 Changed 8 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

comment:8 Changed 8 months ago by Ryan J Ollos

In 17543:

TracMasterTickets 4.0.3: Fix README rst formatting

Refs #13624.

comment:9 Changed 8 months ago by Ryan J Ollos

Thanks for providing the fix. I've published the 4.0.3 to pypi:TracMasterTickets.

comment:10 Changed 8 months ago by Ryan J Ollos

In 17544:

TracMasterTickets 4.0.4dev: Fix documented version requirements

Refs #13624.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.