[PATCH] crashes if there are non-project directories or other files in directory containing projects

[Max Zorloff]

the error is something like this:

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/trac/web/main.py", line 387, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.5/site-packages/trac/web/main.py", line 208, in dispatch
    chrome.populate_hdf(req, chosen_handler)
  File "/usr/local/lib/python2.5/site-packages/trac/web/chrome.py", line 319, in populate_hdf
    for category, name, text in contributor.get_navigation_items(req):
  File "build/bdist.linux-i686/egg/projectmenu/web_ui.py", line 21, in get_navigation_items
    proj_env = _open_environment(os.path.join(search_path, project))
  File "/usr/local/lib/python2.5/site-packages/trac/web/main.py", line 58, in _open_environment
    env_cache[env_path] = open_environment(env_path)
  File "/usr/local/lib/python2.5/site-packages/trac/env.py", line 434, in open_environment
    env = Environment(env_path)
  File "/usr/local/lib/python2.5/site-packages/trac/env.py", line 126, in __init__
    self.verify()
  File "/usr/local/lib/python2.5/site-packages/trac/env.py", line 174, in verify
    fd = open(os.path.join(self.path, 'VERSION'), 'r')
IOError: [Errno 2] No such file or directory: '/home/mmm/VERSION'

[pj@…]

This patch is fairly self explanatory and fixes this bug.

projectmenu/web_ui.py

@@ -18 +18 @@
         
         for project in os.listdir(search_path):
             if project != this_project:
-                proj_env = _open_environment(os.path.join(search_path, project))
+               try:
+                    proj_env = _open_environment(os.path.join(search_path, project))
                 
-                proj_elm = tag.OPTION(proj_env.project_name, value=posixpath.join(base_url, project))
+                    proj_elm = tag.OPTION(proj_env.project_name, value=posixpath.join(base_url, project))
                 
-                projects.append((proj_elm, proj_env.project_name))
+                    projects.append((proj_elm, proj_env.project_name))
+               except IOError:
+                   # IOError means there was a problem reading this
+                   # potential trac instance - it's probably not really
+                   # an instance, so skip it
+                   pass  
         projects.sort(lambda a,b: cmp(a[1],b[1])) # Sort on the project names
         projects.insert(0, (tag.OPTION(self.env.project_name, value=''), None))

[anonymous]

I applied this patches on à 0.10 environement and it works perfectly.

thanks

[Adrian Fritz]

Seems to be a duplicate of #1301, which also have a [PATCH]. Please reopen if different case.

[Ryan J Ollos]

In 14053:

2.0dev: Skip directories that aren't Trac environments. Fixes #1301, Refs #1372.