Modify ↓

Opened 4 years ago

Closed 4 years ago

#13756 closed defect (fixed)

Fails if ticket['type'] contains uppercase

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: CondFieldsGenshiPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

If ticket type value has any upper-case characters, it will not match any pattern, regardless of whether the pattern contains the proper cases or not.

At a glance, I think the issue is here: 

matches_type_cond |= ticket_type == cond.lower()

ticket_type is not .lower() but cond is--so if there are any uppercase in ticket['type'], this will never match. We should either lower both, or not lower both.

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by Ryan J Ollos

Owner: changed from Reinhard Wobst to Ryan J Ollos
Status: new → accepted

comment:2 Changed 4 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 17702:

CondFieldsGenshiPlugin 0.3dev: Don't lower before comparison

Fixes #13756.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.