Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13832 closed enhancement (fixed)

Don't use Genshi for HTML fragment creation

Reported by: Cinc-th Owned by: Cinc-th
Priority: normal Component: MilestoneTemplatePlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Genshi template engine is used to create the HTML fragments inserted into the different Milestone pages. To start the transition to Trac 1.4+ fragments must be created in another way.

Note that this ticket is not about the usage of ITemplateStreamFilter.

Change

Remove Genshi templating when creating HTML fragments by

  • removing MarkupTemplate() and MarkupTemplate().generate()
  • rewriting templates used internally to use standard python templating

Don't use Jinja as a templating engine so we don't break the plugin for Trac 1.2.

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by Cinc-th

Resolution: fixed
Status: assignedclosed

In 17777:

No longer use Genshi templates when creating HTML fragments. Add a few test cases for checking fragments.

Closes #13832

comment:2 Changed 4 years ago by Cinc-th

This works with Trac 1.2 and Trac 1.4. For the latter Genshi must be installed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.