Modify ↓

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13837 closed defect (fixed)

Does not work with Trac 1.4.1 without Genshi

Reported by: marte@… Owned by: Cinc-th
Priority: normal Component: MultipleWorkflowPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.4

Description

Does not seem to work with Trac 1.4.1 (see Screenshot)

Attachments (1)

MultipleWorkflowPlugin_on_1.4.1.PNG​ (17.6 KB) - added by anonymous 4 years ago.

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by anonymous

Attachment: MultipleWorkflowPlugin_on_1.4.1.PNG​ added

comment:1 in reply to:  description Changed 4 years ago by anonymous

Replying to marte@…:

Does not seem to work with Trac 1.4.1 (see Screenshot)

but: functionality beneath admin interface seems to work

comment:2 Changed 4 years ago by Ryan J Ollos

In 17780:

MultipleWorkflowPlugin 1.4.1.1: Make compatible with Trac 1.4

Refs #13837.

comment:3 Changed 4 years ago by Ryan J Ollos

Owner: changed from Cinc-th to Ryan J Ollos
Status: new → accepted

Template needs to be converted to Jinja2, but it should now be functional with Trac 1.4 if you have Genshi installed.

comment:4 Changed 4 years ago by marte@…

Can confirm 17780 as working on Trac 1.4.1 with Genshi. Thank you!

Shall I close the bug?

comment:5 Changed 4 years ago by Cinc-th

Owner: changed from Ryan J Ollos to Cinc-th
Status: accepted → assigned
Summary: Does not work with Trac 1.4.1 → Does not work with Trac 1.4.1 without Genshi

I'm currently looking into removing Genshi from this plugin so I decided to just hijack the ticket for tracking the effort.

comment:6 Changed 4 years ago by marte@…

perfect. Drop me a note of you need testing.

comment:7 in reply to:  6 Changed 4 years ago by Cinc-th

Replying to marte@…:

perfect. Drop me a note of you need testing.

Very appreciated. Our production system is not running on 1.4 yet so I only have a test installation for testing. Without users hammering the plugin some problems may slip through...

comment:8 Changed 4 years ago by Cinc-th

In 17781:

  • Workflow graph on admin page wasn't refreshed with Trac 1.4 on change
  • Made Genshi a requirement for now

Follow-up to [17780]

Refs #13837

comment:9 in reply to:  5 ; Changed 4 years ago by Ryan J Ollos

Replying to Cinc-th:

I'm currently looking into removing Genshi from this plugin so I decided to just hijack the ticket for tracking the effort.

Thanks! I lost track and mistakenly thought you weren't maintaining.

comment:10 in reply to:  9 Changed 4 years ago by Cinc-th

Replying to Ryan J Ollos:

Replying to Cinc-th:

I'm currently looking into removing Genshi from this plugin so I decided to just hijack the ticket for tracking the effort.

Thanks! I lost track and mistakenly thought you weren't maintaining.

Well, I didn't put the necessary effort into my plugins in the past. So I'm quite thankful for all the bugfixes you made to keep them working.

comment:11 Changed 4 years ago by Cinc-th

In 17782:

  • Fix Javascript for Trac 1.4 for new ticket creation (see #13838)
  • No longer use filter_stream() from ITemplateStreamFilter

closes #13838

Refs #13837

comment:12 Changed 4 years ago by Cinc-th

Resolution: → fixed
Status: assigned → closed

In 17783:

MultipleWorkflowPlugin: use Jinja2 instead of Genshi with Trac 1.4+.

  • No check for Genshi as a requirement anymore (introduced with [17781])
  • compatible with Trac 1.2+, Trac 1.4+

closes #13837

comment:13 Changed 4 years ago by marte@…

can comfirm #13837 and #13838 fixed on Trac 1.4.2. Thank you for the great work!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.