#13865 closed defect (fixed)
[PATCH] ProjectMenuPlugin prevents active navigation item from being highlighted
| Reported by: | anonymous | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Component: | ProjectMenuPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Trac Release: | 1.4 |
Description
I was trying out this plugin on my new Trac 1.4.2 server build, and found that it prevented the active/current navigation item from being highlighted.
It seems that generally this kind of behavior can happen at odd times (when there are errors?), but there did not appear to be any errors shown on the web pages or the log.
I am attaching a patch that fixes the issue, which involves moving the add_script() call and changing the parameters and return value of post_process_request().
I don't know why this fixes the problem. Obviously there's something in the core that doesn't like the previous behavior (even though generally things were working).
I'm not sure if I will end up using this plugin (though it could be convenient) because I think it will be too slow, although I think it's only a hit when the project is first accessed. Right now I'm just testing with a subset of projects.
Attachments (1)
Change History (5)
Changed 4 years ago by
| Attachment: | projectmenuplugin_fix_active_nav_trac_142.patch added |
|---|
comment:1 Changed 4 years ago by
P.S. I just realized, it would probably be prudent to eliminate the reference to Genshi.
from trac.util.html import html as tag
comment:2 Changed 4 years ago by
| Owner: | set to Ryan J Ollos |
|---|---|
| Status: | new → accepted |
comment:4 Changed 4 years ago by
Changes are untested. Please let me know if you encounter any problems.
Fix to allow active navigation item to be highlighted.