Modify ↓

Opened 5 years ago

Closed 5 years ago

#13879 closed defect (fixed)

[PATCH] Prefix custom attribute names with "data-" for HTML5

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: CcSelectorPlugin
Severity: normal Keywords: patch
Cc: Trac Release: 1.4

Description

Due to Trac now needing a new permission to change CC fields (I'm always admin, so how would I know?), I ended up investigating this plugin a bit and found a small enhancement. HTML validator doesn't like the custom attribute names used, but I found out it will like them if you prefix them with "data-".

Attaching a patch for this admittedly minor issue.

I'm not sure how this might affect the markup created by the older Genshi template (it's an older HTML?), but I included the change there (not tested) because obviously the Javascript needed to change as well.

Attachments (1)

ccselectorplugin_make_attribute_names_good_for_html5.patch​ (2.2 KB) - added by anonymous 5 years ago.
Change custom attribute names.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by anonymous

Attachment: ccselectorplugin_make_attribute_names_good_for_html5.patch​ added

Change custom attribute names.

comment:1 Changed 5 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: new → accepted

comment:2 Changed 5 years ago by Ryan J Ollos

In 17856:

TracCcSelector 0.2.1: Add data- prefix to custom HTML attributes

Refs #13879.

comment:3 Changed 5 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.