Modify

Opened 12 months ago

Closed 12 months ago

Last modified 9 months ago

#13885 closed task (fixed)

Support Trac 1.4

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: BreadCrumbsNavPlugin
Severity: normal Keywords:
Cc: clemens Trac Release:

Description

I don't have time to take on maintenance of this plugin or indeed an in-depth knowledge of the finer points of trac plugin implementation.. but needed to get this plugin not to bring down the entire Trac UI when enabled.

Version available here that allows upgrade to work. It appears to work for our use case. YMMV. https://github.com/petebannister/breadcrumbsnavplugin

Attachments (0)

Change History (9)

comment:1 Changed 12 months ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: newaccepted

comment:2 Changed 12 months ago by Ryan J Ollos

This plugin wants to force an Environment upgrade every time the Environment is reloaded when there are breadcrumbs in the session_attributes table. However, the logic in Environment upgrade is wrong because of the misnamed attribute breadcrumbs list -> breadcrumbs_list.

I'm going to change the logic to clear the table without requiring that an Environment upgrade be manually executed.

comment:3 Changed 12 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 17865:

TracBreadCrumbsNav 0.4dev: Make compatible with Trac 1.4+

Fix logic that clears the session_attribute table on
environment reload.

Initial patch by petebannister.

Fixes #13885.

comment:4 Changed 12 months ago by Ryan J Ollos

I changed the plugin name, so you'll need to uninstall the old:

$ pip uninstall BreadCrumbsNav
$ pip install svn+https://trac-hacks.org/svn/breadcrumbsnavplugin/trunk

comment:5 in reply to:  3 Changed 9 months ago by clemens

Replying to Ryan J Ollos:

In 17865: compatible with Trac 1.4+

Hello Ryan

I tested most recent BreadCrumbsNavPlugin 0.4 [17865] with Trac 1.4.2 but could not get it running.

Following error:

2021-01-01 00:45:20,190 Trac[env] INFO: -------------------------------- environment startup [Trac 1.4.2] --------------------------------
2021-01-01 00:45:20,273 Trac[loader] ERROR: Skipping "breadcrumbsnav = breadcrumbsnav.breadcrumbs": ImportError: No module named genshi.filters.transform

I am wondering about breadcrumbs.py referencing genshi.filters.transform. As far as I know Genshi is not supported with Trac 1.4 anymore.

Clemens

comment:6 Changed 9 months ago by clemens

Cc: clemens added

comment:7 Changed 9 months ago by Ryan J Ollos

In 17945:

TracBreadCrumbsNav 0.4dev: Require Genshi

Refs #13885.

comment:8 Changed 9 months ago by Ryan J Ollos

It should work, just checked with Trac 1.4, but you need Genshi installed.

Genshi is still supported in Trac 1.4, but doesn't work in all cases.

Last edited 9 months ago by Ryan J Ollos (previous) (diff)

comment:9 in reply to:  8 Changed 9 months ago by clemens

Replying to Ryan J Ollos:

It should work, just checked with Trac 1.4, but you need Genshi installed.

OK! I uninstalled the old and installed your new revision [17945] which states dependency to Genshi. I did not have Genshi on my Trac 1.4 test machine. Thanks to your change PIP now automatically installed Genshi. Everything fine now!

Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.