Modify

Opened 18 months ago

Last modified 6 months ago

#13907 assigned defect

Make compatible with Trac 1.4 and above

Reported by: Andreas Owned by: Ryan J Ollos
Priority: highest Component: TracHoursPlugin
Severity: blocker Keywords:
Cc: Trac Release: 1.4

Description

It seems like the plugin is not working on 1.4.2, which is really sad as it is such a great plugin! We cannot migrate to 1.4.2 because of this...

Attachments (0)

Change History (12)

comment:1 Changed 18 months ago by Ryan J Ollos

In 17873:

TracHours 0.7.4dev: Fix dependencies

Refs #13907.

comment:2 Changed 18 months ago by Ryan J Ollos

In 17874:

TracHours 0.7.4dev: Remove ipnr attribute from query

The ipnr attribute was removed in Trac 1.3.1
(trac:#11901)

Refs #13907.

comment:3 Changed 18 months ago by Ryan J Ollos

I didn't test extensively, but basic functionality is working. Could you please test further?

comment:4 Changed 18 months ago by Andreas

Sure, I will test it! Thanks a lot Ryan!

comment:5 Changed 18 months ago by Andreas

Owner: changed from EmeCas to Ryan J Ollos
Status: newassigned

I encountered two problems:

1.) I had to disable the sidebar as it seems not to work anymore in Trac 1.4. Before I disabled the sidbar, I got errors on opening a ticket. I assume this issue is caused by the old TicketSidebarProviderPlugin, maybe this needs an update too...

trac.ini:

trachours.web_ui.trachourssidebarprovider = disabled

2.) The menu "Hours" does appear and I can also check and download the recorded hours, but I cannot record hours. Usually, there are two ways of doing this in a ticket: Via the sidebar on todays date (which is not working anymore), and with a click on the amount of "Total hours" on any other date - this is usually a link which leads me to the screen "Edit Hours for Ticket #6194", but now it seems like the permission is missing and I only see the amount (at least, if a user doesn't have the permission, he sees it like I see it with permission).

My testuser has the following permission (plus, he is admin):

  • TICKET_ADD_HOURS
  • TICKET_VIEW_HOURS

Can you please check again?

Thank you!

comment:6 in reply to:  5 Changed 18 months ago by Ryan J Ollos

Replying to Andreas:

Can you please check again?

Yes, I'll investigate soon.

comment:7 Changed 18 months ago by Andreas

That would be great, thank you!

comment:8 in reply to:  7 Changed 15 months ago by EmeCas

Replying to Andreas:

That would be great, thank you!

hi, Andreas, I'm wondering where you are about this? I have started playing with 1.5.x with the hope of making this plugin works, but ir is not getting listed in the admin page, I am not even seeing errors, either I was not able to add the mentioned permissions

comment:9 Changed 15 months ago by Andreas

Hi EmeCas,

I just checked again, I have Trac 1.4.2 running and everything works, except for the sidebar (see comment 5, I had to deactivate this to make it run), so still the same situation.

Maybe you still have TicketSidebarProviderPlugin running which causes problems?

comment:10 Changed 14 months ago by Andreas

Hi EmeCas,

did you use the latest version of ComponentDependencyPlugin? I had problems with the old version as it had a different name (now it's called TracComponentDependency instead of ComponentDependencyPlugin), but with the latest version it's working.

I just noticed that it's not a permission issue for the "Edit Hours for Ticket #6194" screen. When I manually enter http://localhost/hours/6194, I can see the normal screen and I can also add hours there, so it seems like it's just a small issue so that the hyperlink to this page is missing on the ticket site (and of course the sidebar).

Would be great if someone can have a look at it! Thank you!

comment:11 Changed 14 months ago by Andreas

I just tested again, there is only one little showstopper for making this plugin work for Trac 1.4: It's the hyperlink that redirects from the ticket page to ​e.g. http://localhost/hours/6194 which is not showing as a hyperlink, but as a text-only (sum of hours).

I think the sidebar is just a nice to have, but not really necessary.

comment:12 in reply to:  11 Changed 14 months ago by EmeCas

Replying to Andreas:

I just tested again, there is only one little showstopper for making this plugin work for Trac 1.4: It's the hyperlink that redirects from the ticket page to ​e.g. http://localhost/hours/6194 which is not showing as a hyperlink, but as a text-only (sum of hours).

I think the sidebar is just a nice to have, but not really necessary.

Thank you Andreas for your recent comments following this subject, once I get sometime to focus on this I will be back to you with any findings. Last time I could not converge to any particular point about figuring out what is in pending for 1.5.x.

I guess your findings about compatibility to 1.4 could be a alternative start point

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain Ryan J Ollos.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.