Modify ↓
#13918 closed defect (fixed)
Theme doesn't render on error page
Reported by: | Ryan J Ollos | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Component: | TracpathTheme |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 1.0 |
Description (last modified by )
When an error is raised, post_process_request
is called with args (None
, None
, None
). The theme is not rendered in this case: tracpaththeme/0.12/tracpaththeme/theme.py@14390:53#L37, which results in:
If if template:
is removed, the theme renders, but I don't know if there are cases in which this will cause a problem.
Attachments (2)
Change History (7)
Changed 4 years ago by
Attachment: | Screen Shot 2020-12-06 at 07.39.33.jpg added |
---|
comment:1 Changed 4 years ago by
Description: | modified (diff) |
---|
Changed 4 years ago by
Attachment: | Screen Shot 2020-12-06 at 07.45.35.jpg added |
---|
comment:2 Changed 4 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 4 years ago by
comment:5 Changed 4 years ago by
Thanks Jun for the quick fix. I really like the style of this theme.
Note: See
TracTickets for help on using
tickets.
Thanks for the reporting. Your suggestion is correct. I just verified applying the theme when
TracError
orException
(e.g.ValueError
, ...) is raised. I commit the changes soon.