Modify ↓

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13918 closed defect (fixed)

Theme doesn't render on error page

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: normal Component: TracpathTheme
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description (last modified by Ryan J Ollos)

When an error is raised, post_process_request is called with args (None, None, None). The theme is not rendered in this case: tracpaththeme/0.12/tracpaththeme/theme.py@14390:53#L37​, which results in:

If if template: is removed, the theme renders, but I don't know if there are cases in which this will cause a problem.

Attachments (2)

Screen Shot 2020-12-06 at 07.39.33.jpg​ (42.8 KB) - added by Ryan J Ollos 5 years ago.
Screen Shot 2020-12-06 at 07.45.35.jpg​ (31.0 KB) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Ryan J Ollos

Attachment: Screen Shot 2020-12-06 at 07.39.33.jpg​ added

comment:1 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

Changed 5 years ago by Ryan J Ollos

Attachment: Screen Shot 2020-12-06 at 07.45.35.jpg​ added

comment:2 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:3 Changed 5 years ago by Jun Omae

Thanks for the reporting. Your suggestion is correct. I just verified applying the theme when TracError or Exception (e.g. ValueError, ...) is raised. I commit the changes soon.

comment:4 Changed 5 years ago by Jun Omae

Resolution: → fixed
Status: new → closed

In 17909:

tracpaththeme: apply the theme even when an error is raised (closes #13918)

Suggested by rjollos

comment:5 Changed 5 years ago by Ryan J Ollos

Thanks Jun for the quick fix. I really like the style of this theme.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.