Modify

Opened 7 months ago

Last modified 6 months ago

#13963 new defect

arrow icon for the drop down menu does not disappear

Reported by: clemens Owned by: Jun Omae
Priority: normal Component: TracDragDropPlugin
Severity: trivial Keywords: patch
Cc: Trac Release:

Description

The TracDragDropPlugin has a minor usability issue: The arrow icon for the drop down menu does not disappear if the mouse focus is left. I would expect that this arrow icon should disappear when the mouse leaves the attachment region.

I am talking about most recent TracDragDropPlugin version 0.12.0.15, revision r17646, 2020-01-07.

This is the arrow symbol which is driven by Javascript:

<div class="tracdragdrop-icon">▼</div>

I propose a tiny patch: attachment:tracdragdrop.js.diff. Basically it registers a mouseleave event which will hide the arrow icon.

Attachments (3)

tracdragdrop.js.diff (854 bytes) - added by clemens 7 months ago.
registers a mouseleave event which will hide the arrow icon.
tracdragdrop2.js.diff (1.4 KB) - added by clemens 7 months ago.
improved 2nd patch which upon mouse-leave does not hide the arrow symbol if the drop down menu is open
tracdragdrop3.js.diff (905 bytes) - added by clemens 7 months ago.
shorter patch file

Download all attachments as: .zip

Change History (7)

Changed 7 months ago by clemens

Attachment: tracdragdrop.js.diff added

registers a mouseleave event which will hide the arrow icon.

Changed 7 months ago by clemens

Attachment: tracdragdrop2.js.diff added

improved 2nd patch which upon mouse-leave does not hide the arrow symbol if the drop down menu is open

comment:1 Changed 7 months ago by clemens

Some more testing reveals that my proposed first patch is not meaningful. It indeed hides the arrow symbol as promised, but unfortunately it renders the drop down menu unusable because it also hides drop down menu as soon as the mouse focus is left.

I have a second patch which will not hide anything as long as the drop down menu is open.

After all this whole issue is just minor usability and probably a matter of taste. It may not be worth to discuss about it ...

Changed 7 months ago by clemens

Attachment: tracdragdrop3.js.diff added

shorter patch file

comment:2 Changed 7 months ago by clemens

By mistake the previous second patch contained too much changes.

Here is a shorter third patch. As described earlier:

  • It will register a mouseleave event which will hide the arrow icon if mouse leaves focus.
  • ... but not if the drop down menu is open.

I tested this. It works well with my TRAC 1.4.2. Without this patch the little arrow symbol will stay forever.

comment:3 Changed 7 months ago by Jun Omae

Severity: minortrivial

I don't think that is a defect. At least, I thought the behavior is reasonable and intentional during develop of the plugin.

Apart from that, the behavior which the icon doesn't appear when the mouse pointer is on left side of attachment list not useful, I think.

Last edited 7 months ago by Jun Omae (previous) (diff)

comment:4 in reply to:  3 Changed 6 months ago by clemens

Replying to Jun Omae:

I would not claim that my patch is perfect and the only truth. This is just a minor usability issue. People often have different understanding of what is "right or wrong" with usability. And indeed, your are right, it is not a typical defect. With or without the patch the TracDragDropPlugin is very useful.

Jun, as the maintainer of the plugin it is your decision...

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Jun Omae.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.