Modify ↓

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#14020 closed defect (fixed)

Doesn't work with Trac 1.4

Reported by: Cinc-th Owned by: Cinc-th
Priority: normal Component: ThemeEnginePlugin
Severity: normal Keywords:
Cc: Trac Release: 1.4

Description

The plugin doesn't work with Trac 1.4 even when Genshi is installed.

I'm willing to commit the necessary changes if you are fine with that. If not I may provide patches.

Attachments (0)

Change History (5)

comment:1 in reply to:  description Changed 3 years ago by Ryan J Ollos

Owner: changed from Olemis Lang to Cinc-th
Status: new → assigned

Replying to Cinc-th:

I'm willing to commit the necessary changes if you are fine with that. If not I may provide patches.

Please feel free to go ahead.

comment:2 Changed 3 years ago by Cinc-th

In 18322:

ThemeEnginePlugin: fix theme engine admin pages for Trac 1.4. Note that still Genshi templates are used.

Refs #14020

comment:3 Changed 3 years ago by Cinc-th

In 18326:

ThemeEnginePlugin: use Jinja2 or Genshi theme templates depending on the template type currently rendered. Note that the theme has to provide both. If only one type is available the other type of templates will be rendered without a custom theme.

Refs #14020

comment:4 Changed 3 years ago by Cinc-th

Resolution: → fixed
Status: assigned → closed

In 18328:

ThemeEnginePlugin: compatibility fixes for Trac 1.4 and Trac 1.6.

  • created Jinja2 templates.
  • Fix for exception when trying to render error page using Trac 1.4 and Trac 1.6
  • New version of jquery.rule.js fixes problem where colors weren't applied to the input fields after color scheme selection in custom panel.
  • Python 3 fixes.
  • Fixed test cases where custom theme components weren't loaded into the environment.

Closes #14020

comment:5 Changed 3 years ago by Cinc-th

The plugin now also works with Python 3 and Trac 1.6.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.