Modify

Opened 10 months ago

Closed 9 months ago

#14078 closed defect (fixed)

Endless recursion resolving groups

Reported by: Joachim Mairböck Owned by: Ryan J Ollos
Priority: normal Component: LdapPlugin
Severity: critical Keywords:
Cc: Trac Release: 1.2

Description

The optimized way of resolving groups introduced in #13537 currently leads to an endless recursion. The found groups need to be added to the list before making the recursive call, i.e. the lines ldapplugin/0.12/ldapplugin/api.py@17390:177-178#L177 need to be swapped.

Attachments (1)

fix17048.patch (792 bytes) - added by Joachim Mairböck 10 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 months ago by Ryan J Ollos

I don't have a configuration to test. Would you be able to create a patch (trac:TracDev/SubmittingPatches)?

Changed 10 months ago by Joachim Mairböck

Attachment: fix17048.patch added

comment:2 Changed 10 months ago by Joachim Mairböck

I have attached a patch.

I have converted the plugin to a git repository. We use Active directory, so I injected the version from #6268 at the supposedly correct time in history and rebased the newer changes on top of it. I also did a few more fixes to make it actually work with (our) AD. I am not sure what to with these changes. I just reported this for now because it is an obvious bug which likely affects everyone.

Should I attach my other changes to ticket #6268?

comment:3 in reply to:  2 Changed 9 months ago by Ryan J Ollos

Replying to Joachim Mairböck:

Should I attach my other changes to ticket #6268?

Yeah, that would be great.

comment:4 Changed 9 months ago by Ryan J Ollos

Owner: changed from Sylvain Delisle to Ryan J Ollos
Status: newaccepted

comment:5 Changed 9 months ago by Ryan J Ollos

In 18457:

LdapPlugin 0.7.0dev: Fix recurrsion resolving groups

Patch by Joachim Mairböck.

Refs #14078, #13537.

comment:6 Changed 9 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.