Modify ↓

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#14173 closed defect (fixed)

Port Python 3.10.8

Reported by: jean Owned by: Jun Omae
Priority: normal Component: GraphvizPlugin
Severity: normal Keywords: patch
Cc: stefgers Trac Release: 1.4

Description

The attached patch seems to make the plug-in work on python 3.10.8:

  • run 2to3
  • replaced 'sha' by 'hashlib'

Exact version:

Paquetage Version
Trac 1.5.3
Babel 2.9.1
Jinja2 2.11.3
pysqlite 2.6.0
Python 3.10.8
pytz 2022.6
setuptools 59.6.0
SQLite 3.36.0
jQuery 1.12.4
jQuery UI 1.12.1
jQuery Timepicker 1.6.3

Attachments (2)

14173.patch​ (3.5 KB) - added by anonymous 2 years ago.
stefgers.diff​ (6.9 KB) - added by stefgers 2 years ago.
in addition deleting Genshi-dependency

Download all attachments as: .zip

Change History (11)

Changed 2 years ago by anonymous

Attachment: 14173.patch​ added

Changed 2 years ago by stefgers

Attachment: stefgers.diff​ added

in addition deleting Genshi-dependency

comment:1 Changed 2 years ago by stefgers

the patch (stefgers.diff​) does also delete the Genshi-dependency
this makes it fully compatible with Trac >1.5
However: it breaks up with python 2.7 because of str/unicode checkings

comment:2 Changed 2 years ago by stefgers

Cc: stefgers added

comment:3 Changed 2 years ago by figaro

Keywords: patch added

comment:4 in reply to:  1 Changed 2 years ago by Jun Omae

Owner: changed from Christian Boos to Jun Omae
Status: new → accepted

Replying to stefgers:

the patch (stefgers.diff​) does also delete the Genshi-dependency
this makes it fully compatible with Trac >1.5
However: it breaks up with python 2.7 because of str/unicode checkings

Thanks, but we should not remove sanitizer or leave unnecessary codes as comments.

I'd like to make compatible with Trac 1.4/1.6 and Python 2/3.

comment:5 Changed 2 years ago by Jun Omae

Resolution: → fixed
Status: accepted → closed

In 18525:

Make compatible with Trac 1.5.4 and Python 3, and remove Genshi from dependencies (closes #14173)

comment:6 Changed 2 years ago by Jun Omae

In 18525:

Make compatible with Trac 1.5.4 and Python 3, and remove Genshi from dependencies (closes #14173)

comment:7 in reply to:  6 Changed 2 years ago by stefgers

Replying to Jun Omae:

In 18525:

Make compatible with Trac 1.5.4 and Python 3, and remove Genshi from dependencies (closes #14173)

Great, thanks for that!

I think

  • #5747 is now obsolete, and
  • an update to PyPI should be considered

comment:8 Changed 2 years ago by Ryan J Ollos

Jun, I added you as a package maintainer on PyPI in case you want to publish a new package.

comment:9 Changed 2 years ago by Jun Omae

Thanks. Published ​pypi:TracGraphviz/1.4.0.3, now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.