TracHTTPAuth positional arguments error on Trac 1.6

[Gea-Suan Lin]

We got errors in Trac 1.6:

Trac detected an internal error:
TypeError: HTTPAuthFilter.post_process_request() takes 4 positional arguments but 5 were given

it would "work" (but not tested whether it's functionally correct) if we changed from the first one to the second one:

    def post_process_request(self, req, template, content_type):

    def post_process_request(self, req, template, content_type, metadata=None, method=None):

[Ryan J Ollos]

See ​TracDev/PortingFromGenshiToJinja#ImplementIRequestFilter.post_process_requesttoconditionallyaddJavaScriptcode.

[Gea-Suan Lin]

Thanks, I found the "official" way to allow XmlRpcPlugin and AccountManagerPlugin working together, from https://trac-hacks.org/wiki/XmlRpcPlugin#ProblemswhenAccountManagerPluginisenabled:

[account-manager]
environ_auth_overwrite = false

This way works and I have uninstalled TracHTTPAuth. I guess we can close this ticket if TracHTTPAuth is not maintained anymore.

[Jun Omae]

In 18627:

TracHTTPAuth: fix incorrect parameters of IRequestHandler.post_process_request (refs #14250)

[Jun Omae]

In 18629:

TracHTTPAuth: make compatible with Python 3 and Trac 1.6 (closes #14250)