Python 3 says SyntaxError: multiple exception types must be parenthesized

[clemens]

Running the SearchAllPlugin (revision r18446) on TRAC 1.6 with Python 3 makes problems.

Basically the plugin is supposed to offer a new check-box "All projects" in the search page.

In the log file we can see the error:

2023-11-19 15:58:08,012 Trac[env] INFO: -------------------------------- environment startup [Trac 1.6] --------------------------------
2023-11-19 15:58:08,190 Trac[loader] ERROR: Skipping "tracsearchall = tracsearchall.searchall": 
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/dist-packages/trac/loader.py", line 80, in _load_eggs
    entry.load(require=True)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2468, in load
    return self.resolve()
           ^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2474, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/tracsearchall/searchall.py", line 120
    except Exception, ex:
           ^^^^^^^^^^^^^
SyntaxError: multiple exception types must be parenthesized (searchall.py, line 120)

I am not a Python expert, but source:/searchallplugin/0.11/tracsearchall/searchall.py#L120​ contains except Exception, ex: where it should rather be except Exception as ex:. As I learned from ​here.

[Jun Omae]

Fixed in [18605].

[clemens]

I tested the bugfix and can confirm that revision r18605 works with TRAC 1.6.
Thanks

Shall we consider incrementing the version number for SearchAllPlugin from 0.9 to 0.10?

[Jun Omae]

In 18610:

TracSearchAll 0.10: bump up the version to 0.10 (refs #14254)