Support for Trac 1.6

[Joachim Mairböck]

It would be nice if this plugin was updated to support Trac 1.6.

I understand that this uses ITemplateStreamFilter, so porting it is likely non-trivial.

I have a (probably incomplete) patch with some changes for python 3 compatibility but the actual Trac changes are still missing.

[Joachim Mairböck]

incomplete patch for python 3 support

[Tetsuya Morimoto]

I do not use trac now, so it's difficult to maintain it in the future. I want to delegate maintenance privileges to someone if possible.

[Jun Omae]

Okay. I'll push the proposed patch after reviewing it and testing.

In the patch, I'd suggest using explicit relative import (e.g. from .model import ...) rather than absolute import for Python 2 and 3.

-from model import CUSTOM_FIELDS, TICKETREF, TicketLinks
-from utils import cnv_sorted_refs
+from ticketref.model import CUSTOM_FIELDS, TICKETREF, TicketLinks
+from ticketref.utils import cnv_sorted_refs

-from utils import cnv_list2text, cnv_sorted_refs, cnv_text2list
+from ticketref.utils import cnv_list2text, cnv_sorted_refs, cnv_text2list

[Jun Omae]

In 18616:

TracTicketReferencePlugin: make compatible with Trac 1.6 (closes #14274)

[Jun Omae]

In 18617:

TracTicketReferencePlugin: modify Python in the classifiers with 2.7 and 3, and enable [bdist_wheel] universal option (refs #14274)

[Tetsuya Morimoto]

I appreciate maintaining this plugin. Thank you!

[Joachim Mairböck]

Thank you for (nearly) fixing this so fast!

One minor thing is still missing: web_ui.py is using reduce(), so it is missing a from functools import reduce. Can you fix this please?

[Jun Omae]

In 18618:

TracTicketReferencePlugin: fix missing import for reduce (refs #14274)

[Jun Omae]

Oh, I missed it. I've ran tests and confirmed tests passing, however I didn't notice no tests for web_ui.py. Please try the latest. Thanks!

[Joachim Mairböck]

Thanks for the fix!