Tag Index broken for Tag wiki pages with a tilte containing quotes

[anonymous]

Env: Trac 0.10.3, TracTags 0.4 (​http://trac-hacks.org/svn/tagsplugin/trunk), Python 2.4

Example:

For the Tag AOP there exist a wiki page with the name AOP. The tag AOP than doesn't link to the normal tag list (trac.cgi/tags/'AOP'), but to the AOP wiki page (trac.cgi/wiki/AOP)

If the wiki page contains the title

= [wiki:"Aspect-Oriented Programming"] ([wiki:AOP]) =

the Tags page (trac.cgi/tags) is broken because the list entry becomes

<li><a rel="tag" title="[wiki:"Aspect-Oriented Programming"] ([wiki:AOP])  (4)" style="font-size: 11px" href="/cgi-bin/trac.cgi/wiki/AOP">AOP</a></li>

There is no error message in the log an the list entry is not visible in the HTML sources.

It happens in tractags/macros.py (around line 126) in out.write(...).

Maybe it would be sufficient to quote taginfo[tag][1]. A quick experiment with {{{urllib.quote()}} didn't yield the desired result.

[anonymous]

Applies as well to render_listtagged() in tractags/macros.py

Probably all occurrences of taginfo[tag][1] are at risk (if they are used as a quoted XML/HTML attribute)

[John Hampton]

Patch to escape quotes in titles

[John Hampton]

OK, I attached a simple patch that converts double quotes to single quotes. It's not exactly ideal, but I don't think there is another solution. The biggest issue being that entities and escaped values aren't rendered in the tool tips.

Anyway, it works for me.

[Alec Thomas]

This is no longer an issue because page titles aren't rendered in 0.6.