Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1684 closed defect (fixed)

Management page has lost association with the reports

Reported by: Colin Guthrie Owned by: Russ Tyndall
Priority: normal Component: TimingAndEstimationPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

I really want to use this plugin but I'm stumped!

On the Management page all of the reports just link to the Management page again. It's like the links have lost their association with the the report numbers.

I have the latest svn version running on Trac 0.10.4. I have upgraded this in the past and run the necessary trac-admin commands but no joy. Everything is up-to-date now AFAICT.

Attachments (0)

Change History (7)

comment:1 Changed 10 years ago by Russ Tyndall

It sounds like you have javascript disabled or that an error was introduced. Those links are built with javascript based on the rest of the form when you mouse over them. Check for javascript errors and let me know what you find.

Cheers,

Russ

comment:2 Changed 10 years ago by Colin Guthrie

Indeed! Thanks for the tip. It seems that linkify() is not defined. A little probing (e.g. looking at the source and it seems that the chrome/Billing/linkifyer.js is not working right. It seems to be an incompatibility with the BatchModifyPlugin.

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 406, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.5/site-packages/trac/web/chrome.py", line 226, in process_request
    in provider.get_htdocs_dirs() if dir[0] == prefix]:
AttributeError: 'BatchModifyModule' object has no attribute 'get_htdocs_dirs'

Should this be fixed here or there?

comment:3 Changed 10 years ago by Russ Tyndall

I think that his plugin is to blame because it only implements 1 of the 2 ITemplateHandler functions. I think that if he implements the following function, everything should work, though I am not sure whether it is looking for None, or an empty [].

  def get_htdocs_dirs(self):
     return None

http://trac-hacks.org/browser/batchmodifyplugin/0.10/batchmod/web_ui.py

comment:4 Changed 10 years ago by Russ Tyndall

Resolution: fixed
Status: newclosed

comment:5 Changed 10 years ago by Russ Tyndall

looking at the exception further I think he wants to make that

  def get_htdocs_dirs(self):
     return []

comment:6 Changed 10 years ago by Colin Guthrie

Thanks yes that fixes it. I'll open a ticket against BatchModifyPlugin.

comment:7 Changed 10 years ago by Colin Guthrie

Seems #1337 already documents this problem. I've added a patch there. Thanks again.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Russ Tyndall.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.