Opened 18 years ago
Closed 3 years ago
#186 closed enhancement (wontfix)
[Patch] Inline CSS
| Reported by: | Noah Kantrowitz | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | LastModifiedMacro |
| Severity: | normal | Keywords: | |
| Cc: | HorsePunchKid | Trac Release: | 0.10 |
Description
For a short piece of CSS like you show for your macro, it is usually eaisier to inline it into a style element. Alternatively you can repackage this as a plugin, which can provide its own CSS.
Attachments (1)
Change History (8)
comment:1 Changed 18 years ago by
| Status: | new → assigned |
|---|---|
| Trac Release: | → 0.8 |
comment:2 Changed 18 years ago by
| Trac Release: | 0.8 → 0.9 |
|---|
comment:3 Changed 18 years ago by
| Cc: | HorsePunchKid added; anonymous removed |
|---|---|
| Owner: | changed from HorsePunchKid to Anton Graham |
| Status: | assigned → new |
| Trac Release: | 0.9 → 0.10 |
I'm going to give the conversion to plugin a shot. This has been sitting idle for a while.
Changed 18 years ago by
| Attachment: | convert_to_plugin_inline_css_patch.diff added |
|---|
Not exactly really a patch, more like the source for the 0.10 version :p
comment:4 Changed 18 years ago by
| Status: | new → assigned |
|---|
Alright, the patch really creates a new plugin for 0.10. It handles the issue for for #186 (though the CSS insertion needs refinement, it's brute forced in). Argument parsing has been completely reworked (would be nice to have a standardized parser ;p). It also handles the issue that is going to start to pop up as people transition to 0.10 and that is split_page_names. The plugin will work even with that option on, but the 0.9 macro will not (though it works as advertised in 0.10 without that option set).
Not sure if I should set the plugin up as a new hack or what, but here it is (sortof :p)
comment:5 Changed 14 years ago by
| Owner: | changed from Anton Graham to Ryan J Ollos |
|---|---|
| Status: | assigned → new |
| Summary: | Inline CSS → [Patch] Inline CSS |
comment:6 Changed 4 years ago by
| Owner: | Ryan J Ollos deleted |
|---|
comment:7 Changed 3 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
This is no longer applicable.
I would be willing to convert it to a plugin if the overhead is relatively small; I don't know anything about the plugin architecture, though. Would this prevent your CSS for the macro from getting clobbered when you update your trac install?