Modify

Opened 10 years ago

Closed 5 years ago

#2032 closed defect (worksforme)

[Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin

Reported by: spike@… Owned by: Ryan J Ollos
Priority: normal Component: SimpleTicketPlugin
Severity: minor Keywords:
Cc: Ryan J Ollos, falkb Trac Release: 0.10

Description (last modified by Ryan J Ollos)

Using PrivateTicketPlugin and giving users one of the added permissions instead of TICKET_VIEW causes a problem in redirect():

     def redirect(self, dest):
        if dest.startswith(self.env.href.ticket()):
            if not (self.req.perm.has_permission('TICKET_VIEW'):
                self.req.redirect(self.env.href.simpleticket())

TICKET_VIEW_REPORTER and TICKET_VIEW_SELF are the only ones to be added because the other permissions do not concern the creation of ticket.

Patch attached.

Attachments (1)

simpleticket.patch (604 bytes) - added by spike@… 10 years ago.
Patch file

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by spike@…

Attachment: simpleticket.patch added

Patch file

comment:1 Changed 10 years ago by Noah Kantrowitz

Simply hard coding those in is not a terribly good solution to me. Using the new security stuff in 0.11 (once PrivateTickets is ported) this should be much cleaner.

comment:2 Changed 8 years ago by Ryan J Ollos

Cc: Ryan J Ollos added; anonymous removed

comment:3 Changed 8 years ago by anonymous

Summary: SimpleTicketPlugin not playing well with PrivateTicketPlugin[Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin

comment:4 Changed 5 years ago by Ryan J Ollos

Cc: falkb added
Owner: changed from Noah Kantrowitz to Ryan J Ollos
Status: newassigned

I'll be testing r10990 with the PrivateTicketsPlugin to see if there are any outstanding issues still.

comment:5 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)
Resolution: worksforme
Status: assignedclosed

I've tested with Trac 0.12.2 and SimpleTicketPlugin is working well with PrivateTicketsPlugin. There is no reference to the TICKET_VIEW in the 0.11 version of SimpleTicketPlugin.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.