Modify

Opened 9 years ago

Closed 7 years ago

#2143 closed defect (fixed)

[Patch] Indexer _strip wrong regexp (non-ascii char issue)

Reported by: slach@… Owned by: Ryan J Ollos
Priority: normal Component: RepoSearchPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

indexer.py line 193

_strip = re.compile(r'\w+')

must be replace _strip = re.compile('[\w_]+',re.U)

Attachments (0)

Change History (7)

comment:1 Changed 9 years ago by Alec Thomas

Resolution: invalid
Status: newclosed

_ is already included by \w.

comment:2 Changed 9 years ago by anonymous

Resolution: invalid
Status: closedreopened

when not using re.U, non-ascii character not indexed

comment:3 Changed 7 years ago by Ryan J Ollos

Reassigning ticket after changing maintainer of plugin.

comment:4 Changed 7 years ago by Ryan J Ollos

Owner: changed from Alec Thomas to Ryan J Ollos
Status: reopenednew

comment:5 Changed 7 years ago by Ryan J Ollos

Summary: Indexer _strip wrong regexpIndexer _strip wrong regexp (non-ascii char issue)

There seem to be numerous reports related to us of non-ascii characters. I will test out your fix, but could really use someone to test on their non-english installation.

comment:6 Changed 7 years ago by Ryan J Ollos

Summary: Indexer _strip wrong regexp (non-ascii char issue)[Patch] Indexer _strip wrong regexp (non-ascii char issue)

comment:7 Changed 7 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

(In [8523]) Fixed problem with indexing non-ascii characters. Fixes #2143.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.