Modify ↓
#2169 closed defect (fixed)
Plugin throws if non-directories exist in trac environment root
Reported by: | Jason Winnebeck | Owned by: | anonymous |
---|---|---|---|
Priority: | normal | Component: | SearchAllPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.10 |
Description
Plugin fails if non-directories exist in trac environment root, below is a patch to ensure that the file isn't a directory before trying to open it as a environment. Not included in this patch as I didn't need it would be to also catch an exception from the open environment command, because even if it is a directory it's possible that it is not a Trac environment.
-
tracsearchall/searchall.py
52 52 # skip our own project 53 53 if project == this_project: 54 54 continue 55 55 56 56 # make up URL for project 57 57 project_url = '/'.join( (base_url, project) ) 58 58 59 59 project_path = os.path.join(search_path,project) 60 if not os.path.isdir( project_path ): 61 continue 62 60 63 env = open_environment(project_path)
Attachments (0)
Change History (3)
comment:1 Changed 17 years ago by
Owner: | changed from Álvaro Iradier to anonymous |
---|---|
Status: | new → assigned |
comment:2 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Applied, thanks